[ci/failed_tests_reporter] when Github 500s, retry up to 5 times #47740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
This comment has been minimized.
This comment has been minimized.
jbudz
approved these changes
Oct 9, 2019
💔 Build Failed |
added 2 commits
October 9, 2019 17:04
…led_tests_reporter/retries
💚 Build Succeeded |
This was referenced Oct 10, 2019
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Oct 10, 2019
…tic#47740) * [ci/failed_tests_reporter] when Github 500s, retry up to 5 times * remove unused import * properly handle non-string headers
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Oct 10, 2019
…tic#47740) * [ci/failed_tests_reporter] when Github 500s, retry up to 5 times * remove unused import * properly handle non-string headers
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Oct 10, 2019
…tic#47740) * [ci/failed_tests_reporter] when Github 500s, retry up to 5 times * remove unused import * properly handle non-string headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got a failure on master because Github responded with a 500 and we don't have any error handling in the new failed tests reporter introduced by #46993. This update adds retry logic that will make up to 5 attempts, only retrying if Github couldn't be reached, or if we receive a 500 response, and waiting
attempt * 1000ms before each subsequent attempt.