-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIEM Remove GraphiQL #48135
Merged
Merged
[SIEM Remove GraphiQL #48135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierM
added
release_note:skip
Skip the PR/issue when compiling release notes
Team:SIEM
v7.5.0
v8.0.0
labels
Oct 14, 2019
Pinging @elastic/siem (Team:SIEM) |
XavierM
force-pushed
the
siem-no-more-graphiql
branch
from
October 14, 2019 18:01
cf365c4
to
c1256dc
Compare
kobelb
approved these changes
Oct 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this @XavierM!
spong
approved these changes
Oct 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally -- LGTM 👍
XavierM
force-pushed
the
siem-no-more-graphiql
branch
from
October 16, 2019 18:30
bf31da5
to
9759485
Compare
XavierM
force-pushed
the
siem-no-more-graphiql
branch
from
October 16, 2019 19:43
9759485
to
7d7781f
Compare
💔 Build Failed
|
💚 Build Succeeded |
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Oct 17, 2019
* remove GraphIql in production * fix api intergation on CI
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Oct 17, 2019
* remove GraphIql in production * fix api intergation on CI
XavierM
added a commit
that referenced
this pull request
Oct 17, 2019
XavierM
added a commit
that referenced
this pull request
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are removing GraphiQl, base on this issue https://github.com/elastic/kibana-team/issues/145
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately