Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM Remove GraphiQL #48135

Merged
merged 2 commits into from
Oct 16, 2019
Merged

[SIEM Remove GraphiQL #48135

merged 2 commits into from
Oct 16, 2019

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Oct 14, 2019

Summary

We are removing GraphiQl, base on this issue https://github.com/elastic/kibana-team/issues/145

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@XavierM XavierM requested a review from kobelb October 14, 2019 17:16
@XavierM XavierM self-assigned this Oct 14, 2019
@XavierM XavierM added release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.5.0 v8.0.0 labels Oct 14, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@XavierM XavierM requested a review from spong October 14, 2019 17:17
@XavierM XavierM force-pushed the siem-no-more-graphiql branch from cf365c4 to c1256dc Compare October 14, 2019 18:01
Copy link
Contributor

@kobelb kobelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this @XavierM!

@elastic elastic deleted a comment from elasticmachine Oct 14, 2019
@elastic elastic deleted a comment from elasticmachine Oct 14, 2019
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally -- LGTM 👍

@XavierM XavierM force-pushed the siem-no-more-graphiql branch from bf31da5 to 9759485 Compare October 16, 2019 18:30
@elastic elastic deleted a comment from elasticmachine Oct 16, 2019
@XavierM XavierM force-pushed the siem-no-more-graphiql branch from 9759485 to 7d7781f Compare October 16, 2019 19:43
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@XavierM XavierM merged commit 2335902 into elastic:master Oct 16, 2019
XavierM added a commit to XavierM/kibana that referenced this pull request Oct 17, 2019
* remove GraphIql in production

* fix api intergation on CI
XavierM added a commit to XavierM/kibana that referenced this pull request Oct 17, 2019
* remove GraphIql in production

* fix api intergation on CI
XavierM added a commit that referenced this pull request Oct 17, 2019
* remove GraphIql in production

* fix api intergation on CI
XavierM added a commit that referenced this pull request Oct 23, 2019
* remove GraphIql in production

* fix api intergation on CI
@XavierM XavierM deleted the siem-no-more-graphiql branch June 4, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.5.0 v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants