Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [SIEM] Adds custom tooltip to map for dragging fields to timeline (#46879) #48357

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Oct 16, 2019

Backports the following commits to 7.x:

…astic#46879)

## Summary

Resolves elastic#46301, by adding a custom tooltip for the map that enables dragging to the timeline.

##### Features:
* Adds new portal pattern to enable DnD from outside the main react component tree
* Adds `<DraggablePortalContext>` component to enable DnD from within an `EuiPopover`
  * Just wrap `EuiPopover` contents in `<DraggablePortalContext.Provider value={true}></...>` and all child `DefaultDraggable`'s will now function correctly
* Displays netflow renderer within tooltip for line features, w/ draggable src/dest.bytes
* Displays detailed description list within tooltip for point features. Fields include:
  * host.name
  * source/destination.ip
  * source/destination.domain 
  * source/destination.geo.country_iso_code
  * source/destination.as.organization.name
* Retains ability to add filter to KQL bar

![map_custom_tooltips](https://user-images.githubusercontent.com/2946766/66288691-64c74f00-e897-11e9-9845-54e8c9b9c5ab.gif)


### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spong spong merged commit c81150b into elastic:7.x Oct 16, 2019
@XavierM XavierM deleted the backport/7.x/pr-46879 branch June 4, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants