Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] EMS add data card #48678

Merged
merged 4 commits into from
Oct 22, 2019
Merged

[Maps] EMS add data card #48678

merged 4 commits into from
Oct 22, 2019

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Oct 18, 2019

Fixes #42976

This PR adds Add Data card for EMS boundaries, providing instructions on how to download EMS boundaries and upload into Elasticsearch.

To view the card, go to Kibana home page, click "Add log data". Then select the "All" tag. Select EMS boundaries card.

Screen Shot 2019-10-22 at 8 14 20 AM

Screen Shot 2019-10-22 at 8 20 48 AM

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@nreese
Copy link
Contributor Author

nreese commented Oct 21, 2019

Feedback from gchaps.

replace long description with

"
Elastic Maps Service
hosts tile layers and vector shapes of administrative boundaries. Indexing EMS administrative boundaries in Elasticsearch allows for search on boundary property fields.
"

remove periods from titles.

break download into numbered list

@gchaps
Copy link
Contributor

gchaps commented Oct 21, 2019

Here's what I am thinking. @nreese Can you verify that the steps are correct?

Elastic Maps Service hosts tile layers and vector shapes of administrative boundaries. Indexing EMS administrative boundaries in Elasticsearch allows for search on boundary property fields.

Download EMS boundaries

  1. Navigate to the EMS landing page.
  2. In the left sidebar, select an administrative boundary.
  3. Click the Download GeoJSON button.

Index EMS boundaries

  1. Open Elastic Maps.
  2. Click Add layer, and then select Uploaded GeoJSON.
  3. Upload a GeoJSON file and click Import file.

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the acronym EMS is only used internally, so I would change the title to

Elastic Maps Service Boundaries

And in the description, do something like Elastic Maps Service (EMS).

@gchaps
Copy link
Contributor

gchaps commented Oct 21, 2019

Just checked our style guidelines. In external-facing copy, we do not use the abbreviation EMS.

@nreese
Copy link
Contributor Author

nreese commented Oct 22, 2019

I think the acronym EMS is only used internally, so I would change the title to Elastic Maps Service Boundaries

We use EMS acronym in the select source titles in the maps app. Should those be changed?

@gchaps
Copy link
Contributor

gchaps commented Oct 22, 2019

The guidelines are being updated to say that we can use the abbreviation when space is limited. So using EMS in the source titles is ok.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@nreese nreese merged commit 82382a6 into elastic:master Oct 22, 2019
nreese added a commit to nreese/kibana that referenced this pull request Oct 22, 2019
* [Maps] EMS add data card

* review feedback

* use EMS abbr in card title
nreese added a commit that referenced this pull request Oct 22, 2019
* [Maps] EMS add data card

* review feedback

* use EMS abbr in card title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maps] Add data-upload card to the Kibana data sources landing page for EMS
4 participants