-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] hide map visualization types with default kibana.yml settings #49103
Conversation
Pinging @elastic/kibana-gis (Team:Geo) |
Pinging @elastic/kibana-app (Team:KibanaApp) |
This looks pretty good, but I suspect you need to change the documentation in some way to include this new setting. |
💔 Build Failed |
💔 Build Failed |
@elasticmachine merge upstream |
💔 Build Failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Favorite Maps PR of 7.6 already.. :)
💔 Build Failed |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM (haven't tested), okay from Kibana App side.
@elasticmachine merge upstream |
@nreese What do you think about shortening the text a bit: Opens the Maps app, where you can create and style maps using multiple layers and indices. Is this a strong enough indication that the user is switching apps? I also thought of "Navigate to" |
…map and region map docs
💚 Build Succeeded |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a minor change.
Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>
Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>
💚 Build Succeeded |
💚 Build Succeeded |
…lastic#49103) * [Maps] hide map visualization types with default kibana.yml settings * add docs explaining xpack.maps.showMapVisualizationTypes * clean up docs * fix docs build * fix typescript failures * move docs to troubleshooting section * add message about xpack.maps.showMapVisualizationTypes in coordinate map and region map docs * doc updates based on gchaps feedback * Update docs/visualize/regionmap.asciidoc Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/visualize/tilemap.asciidoc Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>
…49103) (#49585) * [Maps] hide map visualization types with default kibana.yml settings * add docs explaining xpack.maps.showMapVisualizationTypes * clean up docs * fix docs build * fix typescript failures * move docs to troubleshooting section * add message about xpack.maps.showMapVisualizationTypes in coordinate map and region map docs * doc updates based on gchaps feedback * Update docs/visualize/regionmap.asciidoc Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/visualize/tilemap.asciidoc Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>
Too many choices confuse users and clutter interfaces. Users should not have to waste time deciding which map to use. Users should never need to create Coordinate maps or Region maps when Elastic Maps is installed.
User's existing Coordinate map and Region map visualizations are not effected by these changes. Users can still view, edit, and use in dashboards regardless of
xpack.maps.showMapVisualizationTypes
setting.This PR hides Coordinate map and Region map in the create visualization grid, preventing users from creating new Coordinate map and Region map visualizations. This is the default kibana.yml settings when Elastic maps plugin is enabled.
Users can show Coordinate map and Region map in the create visualization grid by setting
xpack.maps.showMapVisualizationTypes: true
in kibana.ymlcc @AlonaNadler @alexfrancoeur @wylieconlon