Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] hide map visualization types with default kibana.yml settings #49103

Merged
merged 13 commits into from
Oct 29, 2019

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Oct 23, 2019

Too many choices confuse users and clutter interfaces. Users should not have to waste time deciding which map to use. Users should never need to create Coordinate maps or Region maps when Elastic Maps is installed.

User's existing Coordinate map and Region map visualizations are not effected by these changes. Users can still view, edit, and use in dashboards regardless of xpack.maps.showMapVisualizationTypes setting.

This PR hides Coordinate map and Region map in the create visualization grid, preventing users from creating new Coordinate map and Region map visualizations. This is the default kibana.yml settings when Elastic maps plugin is enabled.
Screen Shot 2019-10-23 at 12 55 24 PM

Users can show Coordinate map and Region map in the create visualization grid by setting xpack.maps.showMapVisualizationTypes: true in kibana.yml
Screen Shot 2019-10-23 at 12 57 35 PM

cc @AlonaNadler @alexfrancoeur @wylieconlon

@nreese nreese added release_note:enhancement [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v7.6.0 labels Oct 23, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon
Copy link
Contributor

This looks pretty good, but I suspect you need to change the documentation in some way to include this new setting.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@nreese
Copy link
Contributor Author

nreese commented Oct 23, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Favorite Maps PR of 7.6 already.. :)

docs/maps/map-visualizations.asciidoc Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@nreese nreese requested a review from gchaps October 25, 2019 18:38
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM (haven't tested), okay from Kibana App side.

@nreese
Copy link
Contributor Author

nreese commented Oct 28, 2019

@elasticmachine merge upstream

@gchaps
Copy link
Contributor

gchaps commented Oct 28, 2019

@nreese What do you think about shortening the text a bit:

Opens the Maps app, where you can create and style maps using multiple layers and indices.

Is this a strong enough indication that the user is switching apps? I also thought of "Navigate to"

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a minor change.

docs/visualize/regionmap.asciidoc Outdated Show resolved Hide resolved
docs/visualize/tilemap.asciidoc Outdated Show resolved Hide resolved
nreese and others added 2 commits October 28, 2019 16:00
Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>
Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@nreese nreese merged commit ce521bb into elastic:master Oct 29, 2019
nreese added a commit to nreese/kibana that referenced this pull request Oct 29, 2019
…lastic#49103)

* [Maps] hide map visualization types with default kibana.yml settings

* add docs explaining xpack.maps.showMapVisualizationTypes

* clean up docs

* fix docs build

* fix typescript failures

* move docs to troubleshooting section

* add message about xpack.maps.showMapVisualizationTypes in coordinate map and region map docs

* doc updates based on gchaps feedback

* Update docs/visualize/regionmap.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/visualize/tilemap.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>
nreese added a commit that referenced this pull request Oct 29, 2019
…49103) (#49585)

* [Maps] hide map visualization types with default kibana.yml settings

* add docs explaining xpack.maps.showMapVisualizationTypes

* clean up docs

* fix docs build

* fix typescript failures

* move docs to troubleshooting section

* add message about xpack.maps.showMapVisualizationTypes in coordinate map and region map docs

* doc updates based on gchaps feedback

* Update docs/visualize/regionmap.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/visualize/tilemap.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants