Enable interpreter screenshot tests #50089
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
|
|
retest |
💚 Build Succeeded
|
|
retest |
💔 Build Failed
|
Dosant
force-pushed
the
dev/enable-interpretator-screenshot-tests
branch
from
d13d5eb to
c93c632
Compare
This was referenced Nov 8, 2019
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Dosant
commented
Nov 8, 2019
|
|
||
| const metricExpr = | ||
| `metricVis metric={visdimension 1 format="number"} bucket={visdimension 0}`; | ||
| await expectExpression('partial_test_2', metricExpr, context).toMatchScreenshot(); | ||
| `metricVis metric={visdimension 1 format="number"} bucket={visdimension 0} colorRange={range from=0 to=10000}`; |
There was a problem hiding this comment.
I had to specifically pass colorRange, otherwise metricVis renderer failed in runtime
💚 Build Succeeded
|
Dosant
commented
Nov 8, 2019
| @@ -55,6 +55,7 @@ class Main extends React.Component { | |||
|
|
|||
| window.renderPipelineResponse = async (context = {}) => { | |||
| return new Promise(resolve => { | |||
| props.visualizationLoader.destroy(this.chartDiv); | |||
There was a problem hiding this comment.
Makes sure previous visualisation is cleaned up before expected error to capture "empty" screenshot
|
@elasticmachine merge upstream |
Dosant
commented
Nov 11, 2019
| @@ -93,6 +93,7 @@ export const createMetricVisFn = (): ExpressionFunction< | |||
| colorRange: { | |||
| types: ['range'], | |||
| multi: true, | |||
| default: '{range from=0 to=10000}', | |||
There was a problem hiding this comment.
Had to explicitly setup default here, as if not provided, code fails in runtime in react component:
💔 Build Failed
|
💔 Build Failed
|
💚 Build Succeeded
|
Dosant
force-pushed
the
dev/enable-interpretator-screenshot-tests
branch
from
109c5ef to
e943839
Compare
💔 Build Failed
|
…ly passing it in every test
Dosant
force-pushed
the
dev/enable-interpretator-screenshot-tests
branch
from
e943839 to
400cb7d
Compare
|
Closing and will rework because of changes in #46910 |
💔 Build Failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In scope of #50063 I wanted to add a test for a bugfix in expression pipeline and discovered these interpreter functional tests. Most of those were disabled because of #42842 and I wanted to check it it is possible to enable them back
This pr enables back expression pipeline snapshot and screenshots tests
The assumption is:
So, hopefully, we can just enable those back.
In case there are flaky, I have a draft pr which enables just snapshot tests #50080
Checklist
This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately