Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SearchProfiler] Fix console error message when umounting #50105

Merged
merged 4 commits into from
Nov 11, 2019
Merged

[SearchProfiler] Fix console error message when umounting #50105

merged 4 commits into from
Nov 11, 2019

Conversation

jloleysens
Copy link
Contributor

Summary

Fixes this issue on app unmounts (regression introduced after this refactor #48795):

Screenshot 2019-11-08 at 09 41 05

@jloleysens jloleysens added Feature:Dev Tools v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Search Profiler v7.6.0 labels Nov 8, 2019
@jloleysens jloleysens requested a review from sebelga November 8, 2019 14:56
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

sebelga
sebelga approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did not test locally

...egacy/plugins/searchprofiler/public/np_ready/application/containers/profile_query_editor.tsx Outdated
ref!.value = DEFAULT_INDEX_VALUE;
if (ref) {
indexInputRef.current = ref!;
ref!.value = DEFAULT_INDEX_VALUE;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need the exclamation mark now that it is wrapped in the if statement?

@jloleysens
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💔 Build Failed

@jloleysens
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jloleysens jloleysens merged commit 0491589 into elastic:master Nov 11, 2019
@jloleysens jloleysens deleted the fix/searchprofiler-unmount branch November 11, 2019 14:42
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 11, 2019
@jloleysens
[SearchProfiler] Fix console error message when umounting (elastic#50105
ae61a79 
)

* Safer access of input ref

* Remove unnecessary "!" [skip ci]
@jloleysens jloleysens mentioned this pull request Nov 11, 2019
Merged
jloleysens added a commit that referenced this pull request Nov 11, 2019
@jloleysens
[SearchProfiler] Fix console error message when umounting (#50105) (#…
37785f7 
…50157)

* Safer access of input ref

* Remove unnecessary "!" [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebelga sebelga sebelga approved these changes

Assignees
No one assigned
Labels
Feature:Dev Tools Feature:Search Profiler release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jloleysens @elasticmachine @sebelga