Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Query.AI to known-plugins.asciidoc #50516

Merged
merged 2 commits into from
Jan 31, 2020
Merged

Conversation

Kerg09
Copy link
Contributor

@Kerg09 Kerg09 commented Nov 13, 2019

Summary

Added Query.AI's App to the list of known plugins

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

@elasticmachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@Kerg09
Copy link
Contributor Author

Kerg09 commented Nov 13, 2019

@rudolf I've created the new PR from master as your recommended. Thanks for the help.

@Kerg09
Copy link
Contributor Author

Kerg09 commented Dec 9, 2019

@rudolf Sorry to ping you again, but I was curious if you would have just a couple minutes to look at this.

@Kerg09
Copy link
Contributor Author

Kerg09 commented Jan 2, 2020

@jsanchez91 I see you made the last commit for this doc. I was wondering if you could take a look at this quick, I'd appreciate it. Thank you.

@legrego
Copy link
Member

legrego commented Jan 31, 2020

@Kerg09 I'm not sure why it's taken so long for someone to look at this, I apologize for the delay.

@legrego legrego added the release_note:skip Skip the PR/issue when compiling release notes label Jan 31, 2020
@legrego
Copy link
Member

legrego commented Jan 31, 2020

@elasticmachine merge upstream

@legrego legrego added the v8.0.0 label Jan 31, 2020
@legrego
Copy link
Member

legrego commented Jan 31, 2020

Which versions of Kibana do you support?

@Kerg09
Copy link
Contributor Author

Kerg09 commented Jan 31, 2020

We currently support all versions for 6.x and 7.x

@legrego
Copy link
Member

legrego commented Jan 31, 2020

Jenkins, test this

@legrego
Copy link
Member

legrego commented Jan 31, 2020

It's a very straightforward change, but here is a preview of your doc changes: http://kibana_50516.docs-preview.app.elstc.co/guide/en/kibana/master/known-plugins.html

I'll merge this after about an hour unless you find something you wish to change. Otherwise looks good to me! Thanks for your contribution, and thanks for your work on the Kibana plugin.

If you're interested, Elastic now runs a community Slack, and there is a #kibana-development channel that you're free to join if you ever have questions about plugin development.

@Kerg09
Copy link
Contributor Author

Kerg09 commented Jan 31, 2020

Thanks so much, looks great!

@legrego legrego changed the title [7.x]Update known-plugins.asciidoc Adds Query.AI to known-plugins.asciidoc Jan 31, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@legrego legrego merged commit 1bb4d77 into elastic:master Jan 31, 2020
legrego pushed a commit to legrego/kibana that referenced this pull request Jan 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
legrego pushed a commit to legrego/kibana that referenced this pull request Jan 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
legrego pushed a commit to legrego/kibana that referenced this pull request Jan 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
legrego pushed a commit to legrego/kibana that referenced this pull request Jan 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
legrego pushed a commit to legrego/kibana that referenced this pull request Jan 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
legrego pushed a commit to legrego/kibana that referenced this pull request Jan 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
legrego pushed a commit to legrego/kibana that referenced this pull request Jan 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
legrego pushed a commit to legrego/kibana that referenced this pull request Jan 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
legrego added a commit that referenced this pull request Jan 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Kerg09 <46001886+Kerg09@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
legrego added a commit that referenced this pull request Jan 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Kerg09 <46001886+Kerg09@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
legrego added a commit that referenced this pull request Jan 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Kerg09 <46001886+Kerg09@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
legrego added a commit that referenced this pull request Jan 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Kerg09 <46001886+Kerg09@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
legrego added a commit that referenced this pull request Jan 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Kerg09 <46001886+Kerg09@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
legrego added a commit that referenced this pull request Jan 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Kerg09 <46001886+Kerg09@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
legrego added a commit that referenced this pull request Jan 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Kerg09 <46001886+Kerg09@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
legrego added a commit that referenced this pull request Jan 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Kerg09 <46001886+Kerg09@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
legrego added a commit that referenced this pull request Jan 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Kerg09 <46001886+Kerg09@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
legrego added a commit that referenced this pull request Jan 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Kerg09 <46001886+Kerg09@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jfsiii pushed a commit to jfsiii/kibana that referenced this pull request Feb 4, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants