-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move @kbn/es-query into data plugin - kuery folder #51014
Conversation
ad49105
to
c82d463
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1886d95
to
0165c46
Compare
💚 Build Succeeded
|
@lukeelmers @Bargs what do you think about merging these changes and finishing the following items in a separate PR:
|
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
This comment has been minimized.
This comment has been minimized.
After discussion with @Bargs @joshdover and @rudolf, we've confirmed that we will go ahead and merge this once it passes CI. The follow-up task (Option 3 in Rudolf's list above) will be tracked in #51659. |
This comment has been minimized.
This comment has been minimized.
@elasticmachine merge upstream |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💔 Build Failed |
💚 Build Succeeded |
@lukeelmers thank you 🙇♂️ |
Summary
Part of #42885
What should be done in this PR:
@kbn/es-query -> 'src/plugins/data/{server|public}
Migrate all files from ./es-query/kuery to typescript.Will be done in a separate PRChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers