Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hjson version to 3.2.1 #53105

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Conversation

sulemanof
Copy link
Contributor

@sulemanof sulemanof commented Dec 16, 2019

Summary

The lib is used in Vega vis editor.
This upgrade required to get rid of weird behavior of the previous version of the lib.
The reason was described here.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@sulemanof sulemanof marked this pull request as ready for review December 16, 2019 09:45
@sulemanof sulemanof added v7.6.0 v7.7.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Dec 16, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sulemanof sulemanof merged commit 1321892 into elastic:master Dec 17, 2019
@sulemanof sulemanof deleted the update_hjson branch December 17, 2019 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.6.0 v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants