[Monitoring] Added safeguard for some EUI components #53231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igoristic
added
bug
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
lizozom
reviewed
Dec 17, 2019
| @@ -29,3 +29,7 @@ export interface TopNavMenuData { | |||
| disableButton?: boolean | (() => boolean); | |||
| tooltip?: string | (() => string); | |||
| } | |||
|
|
|||
| export interface RegisteredTopNavMenuData extends TopNavMenuData { | |||
There was a problem hiding this comment.
I suspect you have some unrelated commits in this PR
There was a problem hiding this comment.
Indeed. I wrote in #kibana about this boo boo, trying to fix it now.
Sorry for the inconvenience
igoristic
force-pushed
the
mb_setup_fix
branch
from
d6d64b5 to
8378d30
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #52697
This resolves some error/warnings when click on initial no data Metricbeat setup
This was either introduced by https://github.com/elastic/kibana/pull/51100/files#diff-2b7cce7f9c72c72b15f65c30b0aeb499 or
EuiToolTipmakingcontentprop required