[ML] Show model plot info for partitions that do not contain anomalies #53839
Conversation
darnautov
added
release_note:enhancement
:ml
Feature:Anomaly Detection
darnautov
requested review from
walterra,
alvarezmelissa87 and
peteharverson
|
Pinging @elastic/ml-ui (:ml) |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
| @@ -402,11 +402,111 @@ export function resultsServiceProvider(callWithRequest) { | |||
| return definition; | |||
| } | |||
|
|
|||
| /** | |||
| * Gets the record of partition filed - values pairs. | |||
There was a problem hiding this comment.
Nit: small typo field - value
| }; | ||
| } | ||
|
|
||
| function getFieldObject(fieldName, values, field) { |
There was a problem hiding this comment.
Nit: We should probably define this before it gets used as good practice.
| * @param latestMs | ||
| * @returns {Promise<*>} | ||
| */ | ||
| async function getPartitionFieldsValues(criteriaFields, earliestMs, latestMs) { |
There was a problem hiding this comment.
I'm not sure about the structure of the query+aggs here.
For example partition_field_name will return all field names, and partition_field_values will return all values.
Is the query done so we can be sure there will be only one partition_field_name returned? Otherwise the values could refer to different names.
To be more on the safe side, the aggregations could be done nested so the values agg is nested below the names agg. That way we'd have a definitive relationship between names+values defined in the response data.
| @@ -124,6 +124,11 @@ declare interface Ml { | |||
|
|
|||
| results: { | |||
| getMaxAnomalyScore: (jobIds: string[], earliestMs: number, latestMs: number) => Promise<any>; | |||
| fetchPartitionFieldsValues: ( | |||
| criteriaFields: Array<{ fieldName: string; fieldValue: any }>, | |||
There was a problem hiding this comment.
For consistency, I think job ID should be passed as a separate parameter, rather than including it in criteriaFields.
| @@ -532,3 +532,11 @@ export function getScheduledEventsByBucket( | |||
| }) | |||
| ); | |||
| } | |||
|
|
|||
| export function fetchPartitionFieldsValues( | |||
| criteriaFields: Array<{ fieldName: string; fieldValue: any }>, | |||
There was a problem hiding this comment.
As above, for consistency with the other functions in here, I think job ID should be passed as a separate parameter, rather than including it in criteriaFields.
| over_field: overField, | ||
| by_field: byField, | ||
| } = await mlResultsService | ||
| .fetchPartitionFieldsValues( |
There was a problem hiding this comment.
The comment above here needs amending, as it no longer no populates the dropdowns with the values for the top records.
| }; | ||
| }), | ||
| { | ||
| range: { |
There was a problem hiding this comment.
As commented in the follow-up, should consider adding an extra term to the filter here, for result_type, depending on whether model plot has been enabled or not.
|
Check #53879 |
Summary
Resolves #52541. Allow selection of partitions that do not contain anomalies.
In the original solution to populate a partitions dropdown, there were a fetching of the first 500 records from
.ml-anomalies-*and extracting partition values. Eventually, many options were omitted. I've created an endpoint to retrieve distinct partitions with aggregations(for now, I limited each aggregation to 100). In the follow-up PR for #52618, I'll extend this endpoint to support wildcard queries for partitions.Checklist
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibility