Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kibanamachine support to Github PR comments #53852

Merged
merged 4 commits into from
Dec 31, 2019

Conversation

brianseeders
Copy link
Contributor

Our Jenkins credential was switched over to kibanamachine, and now PR comments aren't fully working

@brianseeders brianseeders added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:CI Continuous integration v7.6.0 v7.5.1 v7.4.3 v6.8.6 labels Dec 30, 2019
@brianseeders brianseeders requested review from spalger and a team December 30, 2019 18:57
@brianseeders brianseeders self-assigned this Dec 30, 2019
@brianseeders
Copy link
Contributor Author

retest

@brianseeders brianseeders marked this pull request as ready for review December 30, 2019 19:02
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@brianseeders brianseeders merged commit f8f777b into elastic:master Dec 31, 2019
@brianseeders brianseeders deleted the add-kibanamachine branch December 31, 2019 20:15
brianseeders added a commit to brianseeders/kibana that referenced this pull request Dec 31, 2019
* Add kibanamachine support to Github PR comments

* Temporary commit for quick successful pipeline

* Only delete the last comment if it was made by kibanamachine

* Revert "Temporary commit for quick successful pipeline"

This reverts commit d31f579.
brianseeders added a commit to brianseeders/kibana that referenced this pull request Dec 31, 2019
* Add kibanamachine support to Github PR comments

* Temporary commit for quick successful pipeline

* Only delete the last comment if it was made by kibanamachine

* Revert "Temporary commit for quick successful pipeline"

This reverts commit d31f579.
brianseeders added a commit to brianseeders/kibana that referenced this pull request Dec 31, 2019
* Add kibanamachine support to Github PR comments

* Temporary commit for quick successful pipeline

* Only delete the last comment if it was made by kibanamachine

* Revert "Temporary commit for quick successful pipeline"

This reverts commit d31f579.
brianseeders added a commit to brianseeders/kibana that referenced this pull request Dec 31, 2019
* Add kibanamachine support to Github PR comments

* Temporary commit for quick successful pipeline

* Only delete the last comment if it was made by kibanamachine

* Revert "Temporary commit for quick successful pipeline"

This reverts commit d31f579.
brianseeders added a commit that referenced this pull request Jan 1, 2020
* Add kibanamachine support to Github PR comments

* Temporary commit for quick successful pipeline

* Only delete the last comment if it was made by kibanamachine

* Revert "Temporary commit for quick successful pipeline"

This reverts commit d31f579.
brianseeders added a commit that referenced this pull request Jan 1, 2020
* Add kibanamachine support to Github PR comments

* Temporary commit for quick successful pipeline

* Only delete the last comment if it was made by kibanamachine

* Revert "Temporary commit for quick successful pipeline"

This reverts commit d31f579.
brianseeders added a commit that referenced this pull request Jan 1, 2020
* Add kibanamachine support to Github PR comments

* Temporary commit for quick successful pipeline

* Only delete the last comment if it was made by kibanamachine

* Revert "Temporary commit for quick successful pipeline"

This reverts commit d31f579.
brianseeders added a commit that referenced this pull request Jan 1, 2020
* Add kibanamachine support to Github PR comments

* Temporary commit for quick successful pipeline

* Only delete the last comment if it was made by kibanamachine

* Revert "Temporary commit for quick successful pipeline"

This reverts commit d31f579.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 2, 2020
* master:
  Bump year in NOTICE.txt
  Add kibanamachine support to Github PR comments (elastic#53852)
  Add tests to ensure AAD isn't broken after performing a change on an alert / action (elastic#53333)
  Skip failing test suite
  [Vega] Sample [Flights] Airport Connections (Hover Over Airport) visualization not working (elastic#53799)
  Do not remount applications between page navigations (elastic#53851)
  [Canvas] Refactor Canvas to no longer use componentWillReceiveProps (elastic#52129)
  [Canvas] Migrate usage collector to NP plugin (elastic#53303)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 2, 2020
* master:
  Bump year in NOTICE.txt
  Add kibanamachine support to Github PR comments (elastic#53852)
  Add tests to ensure AAD isn't broken after performing a change on an alert / action (elastic#53333)
  Skip failing test suite
  [Vega] Sample [Flights] Airport Connections (Hover Over Airport) visualization not working (elastic#53799)
  Do not remount applications between page navigations (elastic#53851)
  [Canvas] Refactor Canvas to no longer use componentWillReceiveProps (elastic#52129)
  [Canvas] Migrate usage collector to NP plugin (elastic#53303)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 2, 2020
* master:
  Bump year in NOTICE.txt
  Add kibanamachine support to Github PR comments (elastic#53852)
  Add tests to ensure AAD isn't broken after performing a change on an alert / action (elastic#53333)
  Skip failing test suite
  [Vega] Sample [Flights] Airport Connections (Hover Over Airport) visualization not working (elastic#53799)
  Do not remount applications between page navigations (elastic#53851)
  [Canvas] Refactor Canvas to no longer use componentWillReceiveProps (elastic#52129)
  [Canvas] Migrate usage collector to NP plugin (elastic#53303)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 2, 2020
* master:
  Fix suggested value for time_zone in range query (elastic#53841)
  Clean up generic hooks, use react-use instead (elastic#53822)
  Bump year in NOTICE.txt
  Add kibanamachine support to Github PR comments (elastic#53852)
  Add tests to ensure AAD isn't broken after performing a change on an alert / action (elastic#53333)
  Skip failing test suite
  [Vega] Sample [Flights] Airport Connections (Hover Over Airport) visualization not working (elastic#53799)
  Do not remount applications between page navigations (elastic#53851)
  [Canvas] Refactor Canvas to no longer use componentWillReceiveProps (elastic#52129)
  [Canvas] Migrate usage collector to NP plugin (elastic#53303)
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 8, 2020
* Add kibanamachine support to Github PR comments

* Temporary commit for quick successful pipeline

* Only delete the last comment if it was made by kibanamachine

* Revert "Temporary commit for quick successful pipeline"

This reverts commit d31f579.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes v6.8.6 v7.4.3 v7.5.1 v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants