[Telemetry] Fix license page crashing on telemetry.enabled: false #54174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bamieh
added
Feature:Telemetry
v8.0.0
release_note:skip
💚 Build SucceededTo update your PR or re-run it, just comment with: |
Bamieh
added a commit
to Bamieh/kibana
that referenced
this pull request
Jan 8, 2020
This was referenced Jan 8, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 8, 2020
* master: [Telemetry] Fix license page crashing on telemetry.enabled: fa… (elastic#54174)
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Jan 8, 2020
….com:mbondyra/kibana into IS-50036_show-sum-for-a-field-with-formatter * 'IS-50036_show-sum-for-a-field-with-formatter' of github.com:mbondyra/kibana: [Telemetry] Fix license page crashing on telemetry.enabled: fa… (elastic#54174) [ui/public/utils] Copy rarely used items to where they are consumed (elastic#53819) set AppArch team as an owner of the search endpoints (elastic#54131) Don't expose Elasticsearch client as Observable (elastic#53824) [SIEM] Cleanup unnecessary use of enzyme-to-json (elastic#53980)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the license page crashing if
telemetry.enabled: falseconfig is set inkibana.yml.I've used NP to get the
telemetryEnabledflag like we do elsewhere. I've tested all the different configs to make sure they are all working:telemetry.enabled: falsetelemetry.optIn: falsetelemetry.optIn: truecloses #53779