[Maps] Use v7.6 Elastic Maps Service API #54399

nickpeihl · 2020-01-09T20:18:11Z

Summary

This PR updates Kibana to use the v7.6 Elastic Maps Service client and API. Relies on elastic/ems-client#13.

To test this:

EDIT: @elastic/ems-client library@7.6.0 is now published on NPM, so the following steps are unnecessary now.
~~1) Checkout the feature branch from elastic/ems-client#13~~
~~2) In the ems-client directory, run yarn, yarn build, and yarn link.~~
~~3) Checkout this feature branch in Kibana~~
~~4) Run yarn kbn bootstrap and yarn link @elastic/ems-client.~~

EDIT: These steps are no longer necessary, the 7.6 file service API is now available in staging.
~~The 7.6 file service API is not available yet. But we can run this locally.~~
~~1) Checkout the feature branch from elastic/ems-file-service#143~~
~~2) In the ems-file-service directory run yarn and yarn build.~~
~~3) Serve the assets locally npx http-server -p 8085 --cors="kbn-version" dist/vector~~
~~4) Add map.emsFileApiUrl: http://localhost:8085 to your kibana.dev.yml.~~

You should also test this with map.proxyElasticMapsServiceInMaps: true in your kibana.dev.yml.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
~~Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
~~This was checked for keyboard-only and screenreader accessibility~~

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

Dev Docs

Elastic Maps, Coordinate map and Region map visualizations

The undocumented map.manifestServiceUrl setting in kibana.yml has been replaced by map.emsTileApiUrl and map.emsFileApiUrl. These settings configure the base URL for the tile basemap manifest and vector file manifests used in Elastic Maps and the region map and coordinate map.visualizations.

thomasneirynck

package.json and xpack/package.json needs to be updated to emc-client 7.6.0 thx!

x-pack/legacy/plugins/maps/server/routes.js

nickpeihl · 2020-01-14T01:22:16Z

@elasticmachine merge upstream

package.json

src/legacy/server/config/schema.js

x-pack/legacy/plugins/maps/server/routes.js

x-pack/package.json

thomasneirynck

oops, I approved by mistake 🎊 sorry. Some minor comments. Overall, looks great. But need a double-take if the proxy-config work, and I would lock in versions.

Let's also ensure with @gchaps that we have a corresponding release note for this.

src/legacy/server/config/schema.js

…s-7.6

gchaps · 2020-01-14T16:06:24Z

@thomasneirynck @nickpeihl For this PR to be included in the Release Notes, replace the label release_note:skip with release_note:fix or release_note:enhancement. Also, add a label for the area: Team:Geo.

elasticmachine · 2020-01-14T16:38:45Z

Pinging @elastic/kibana-gis (Team:Geo)

nickpeihl · 2020-01-14T16:41:40Z

@elasticmachine merge upstream

…s-7.6

src/core/server/config/deprecation/core_deprecations.ts

thomasneirynck

just minor feedback on the error message. I tested this through proxying and the normal setup.

Can you create a blocker ticket for updating the config to the production URL for files and the landing page, so we don't forget? Thanks!

src/core/server/config/deprecation/core_deprecations.ts

x-pack/legacy/plugins/maps/server/routes.js

nickpeihl · 2020-01-14T22:02:34Z

Can you create a blocker ticket for updating the config to the production URL for files and the landing page, so we don't forget? Thanks!

#54829 and #54830

kibanamachine · 2020-01-14T22:57:40Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: ab1eb75

History

💚 Build #20304 succeeded 28a35fa
💚 Build #20237 succeeded 388ae93
💔 Build #20207 failed c804a5a
💔 Build #20021 failed 9ff392f
💔 Build #19995 failed ee94ebf

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Use v7.6 Elastic Maps Service API

* Use v7.6 Elastic Maps Service API Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* upstream/master: (72 commits) [ML] Calculate model memory limit API integration tests (elastic#54557) Skip flakey index template component integration tests. (elastic#54878) Add label and icon to nested fields in the doc table (elastic#54199) Reverse dependency of home plugin and apm/ml/cloud (elastic#52883) [SIEM][Detection Engine] Order JSON keys, fix scripts, update pre-packaged rules update invalid snapshot add readme note about alerting / manage_api_key cluster privilege (elastic#54639) [SIEM] New Overview Page (elastic#54783) [Uptime] Feature/refactor context initialization (elastic#54494) Upgrade EUI to v18.2.0 (elastic#54786) [SIEM] [Detection engine] from signals to timeline (elastic#54769) [Index Management] Add Mappings Editor to Index Template Wizard (elastic#47562) [SIEM][Detection Engine] Removes deprecated filter from mapping [Maps] Add categorical styling (elastic#54408) Add mapbox-gl-rtl-text library (elastic#54842) [SIEM][Detection Engine] Adds actions to Rule Details (elastic#54828) Lexicographically sort location tags (elastic#54832) [Maps] expand extent filter to tile boundaries (elastic#54276) [Maps] Use v7.6 Elastic Maps Service API (elastic#54399) [DOCS] Adds monitoring setting (elastic#54819) ...

* Use v7.6 Elastic Maps Service API

Use v7.6 Elastic Maps Service API

1503cbd

nickpeihl requested a review from thomasneirynck January 9, 2020 20:18

nickpeihl added 2 commits January 9, 2020 15:10

Fix tests for 7.6

e4f405a

Replace manifestServiceUrl in tests

1f7e393

nickpeihl requested a review from jsanz January 10, 2020 17:56

Merge branch 'master' of https://github.com/elastic/kibana into ems-7.6

20f1bb5

thomasneirynck reviewed Jan 13, 2020

View reviewed changes

x-pack/legacy/plugins/maps/server/routes.js Show resolved Hide resolved

x-pack/legacy/plugins/maps/server/routes.js Show resolved Hide resolved

Update ems-client library

cb26ce7

nickpeihl marked this pull request as ready for review January 13, 2020 21:40

nickpeihl requested review from a team as code owners January 13, 2020 21:40

nickpeihl added release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v8.0.0 labels Jan 13, 2020

nickpeihl requested a review from thomasneirynck January 13, 2020 21:45

Add ems-client dependency to x-pack package.json

49eff5c

Merge branch 'master' into ems-7.6

ee94ebf

thomasneirynck approved these changes Jan 14, 2020

View reviewed changes

package.json Outdated Show resolved Hide resolved

src/legacy/server/config/schema.js Show resolved Hide resolved

x-pack/legacy/plugins/maps/server/routes.js Outdated Show resolved Hide resolved

x-pack/package.json Outdated Show resolved Hide resolved

thomasneirynck requested changes Jan 14, 2020

View reviewed changes

joshdover suggested changes Jan 14, 2020

View reviewed changes

src/legacy/server/config/schema.js Show resolved Hide resolved

nickpeihl added 3 commits January 13, 2020 20:05

fix sprite url

66b6979

pin ems-client dependency version

b718733

Merge branch 'ems-7.6' of https://github.com/nickpeihl/kibana into em…

9ff392f

…s-7.6

Deprecate manifestServiceUrl setting

1ade1fa

nickpeihl added the [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation label Jan 14, 2020

nickpeihl removed the release_note:skip Skip the PR/issue when compiling release notes label Jan 14, 2020

Merge branch 'master' into ems-7.6

c804a5a

thomasneirynck self-requested a review January 14, 2020 16:47

nickpeihl added release_note:deprecation release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. labels Jan 14, 2020

nickpeihl added 2 commits January 14, 2020 09:24

Fix yarn.lock

4980eb2

Merge branch 'ems-7.6' of https://github.com/nickpeihl/kibana into em…

388ae93

…s-7.6

nickpeihl requested review from joshdover and pgayvallet and removed request for jsanz January 14, 2020 17:58

Merge branch 'master' into ems-7.6

28a35fa

joshdover reviewed Jan 14, 2020

View reviewed changes

src/core/server/config/deprecation/core_deprecations.ts Show resolved Hide resolved

thomasneirynck approved these changes Jan 14, 2020

View reviewed changes

src/core/server/config/deprecation/core_deprecations.ts Outdated Show resolved Hide resolved

x-pack/legacy/plugins/maps/server/routes.js Show resolved Hide resolved

thomasneirynck requested a review from joshdover January 14, 2020 20:53

Review feedback

ab1eb75

joshdover approved these changes Jan 14, 2020

View reviewed changes

nickpeihl removed the request for review from pgayvallet January 14, 2020 23:09

nickpeihl merged commit 6c9e4ec into elastic:master Jan 14, 2020

nickpeihl mentioned this pull request Jan 14, 2020

[7.x] [Maps] Use v7.6 Elastic Maps Service API (#54399) #54845

Merged

nickpeihl added a commit to nickpeihl/kibana that referenced this pull request Jan 14, 2020

[Maps] Use v7.6 Elastic Maps Service API (elastic#54399)

6e6d62c

* Use v7.6 Elastic Maps Service API

nickpeihl added a commit that referenced this pull request Jan 15, 2020

[Maps] Use v7.6 Elastic Maps Service API (#54399) (#54845)

1fe0e37

* Use v7.6 Elastic Maps Service API Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020

[Maps] Use v7.6 Elastic Maps Service API (elastic#54399)

06fac4e

* Use v7.6 Elastic Maps Service API

nreese mentioned this pull request Sep 8, 2021

Remove deprecated Core settings #103915

Closed

nickpeihl mentioned this pull request Sep 8, 2021

[Maps] Remove deprecated maps.manifestServiceUrl configuration #111656

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Maps] Use v7.6 Elastic Maps Service API #54399

[Maps] Use v7.6 Elastic Maps Service API #54399

nickpeihl commented Jan 9, 2020 •

edited

Loading

thomasneirynck left a comment

nickpeihl commented Jan 14, 2020

thomasneirynck left a comment

gchaps commented Jan 14, 2020

elasticmachine commented Jan 14, 2020

nickpeihl commented Jan 14, 2020

thomasneirynck left a comment •

edited

Loading

nickpeihl commented Jan 14, 2020 •

edited

Loading

kibanamachine commented Jan 14, 2020

[Maps] Use v7.6 Elastic Maps Service API #54399

[Maps] Use v7.6 Elastic Maps Service API #54399

Conversation

nickpeihl commented Jan 9, 2020 • edited Loading

Summary

Checklist

For maintainers

Dev Docs

Elastic Maps, Coordinate map and Region map visualizations

thomasneirynck left a comment

Choose a reason for hiding this comment

nickpeihl commented Jan 14, 2020

thomasneirynck left a comment

Choose a reason for hiding this comment

gchaps commented Jan 14, 2020

elasticmachine commented Jan 14, 2020

nickpeihl commented Jan 14, 2020

thomasneirynck left a comment • edited Loading

Choose a reason for hiding this comment

nickpeihl commented Jan 14, 2020 • edited Loading

kibanamachine commented Jan 14, 2020

💚 Build Succeeded

History

nickpeihl commented Jan 9, 2020 •

edited

Loading

thomasneirynck left a comment •

edited

Loading

nickpeihl commented Jan 14, 2020 •

edited

Loading