-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.5] Fix for URL field formatter not able to render relative URLs properly. #55702
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Also, I did notice that the code in |
Hi @mike-treadway, thanks for your contribution, and thanks also for your patience. It looks like we missed the window for the last I'm surprised to find this fixed in I am going to ping the @elastic/kibana-app-arch team to help you out from here. They'll review and provide guidance going forward. |
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Thanks @mike-treadway! Really appreciate you taking the time to put up this PR. Looks like this is in relation to our discussion over in #35235 The fix that you saw on Currently we haven't planned a If you'd like, we could go through a review process on this to merge a fix directly to What are your thoughts? Are you able to confirm that everything works for you as expected on the |
@mike-treadway I'm going to go ahead and close this PR as stale since there hasn't been any activity for quite some time. If you'd still like to contribute, feel free to re-open & we can pick the conversation back up. Thanks for your contribution! |
Summary
Fields using a URL fielder formatter with a relative URL were not rendering correctly because the base URL information in Kibana was not being passed down into the formatter. This caused the formatter to not understand how to derive the full URL and instead just returned a with the URL text inside.
Checklist
- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers