[Reporting/NP] Migration of Reporting Security dependency #56046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
(Deprecated) Feature:Reporting
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
tsullivan
commented
Jan 27, 2020
| RouteConfigFactory, | ||
| } from './lib/route_config_factories'; | ||
| import { makeRequestFacade } from './lib/make_request_facade'; |
There was a problem hiding this comment.
more automated re-organization of the imports
pgayvallet
approved these changes
Jan 28, 2020
Comment on lines
20
to
26
| export const authorizedUserPreRoutingFactory = function authorizedUserPreRoutingFn( | ||
| server: ServerFacade, | ||
| plugins: ReportingSetupDeps, | ||
| logger: Logger | ||
| ) { | ||
| const getUser = getUserFactory(server, logger); | ||
| const getUser = getUserFactory(server, plugins, logger); | ||
| const config = server.config(); |
There was a problem hiding this comment.
NIT: unless authorizedUserPreRoutingFactory / getUserFactory are going to be using other plugins later, I would specialize the parameter and use the security contract instead of the whole ReportingSetupDeps object
There was a problem hiding this comment.
later, we'll use the licensing plugin in this area
tsullivan
added
the
release_note:skip
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
that referenced
this pull request
Jan 29, 2020
19 tasks
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 29, 2020
…55831 * '7.x' of github.com:elastic/kibana: (78 commits) Re-enable watcher FireFox functional test (elastic#56112) (elastic#56294) [Metrics UI] Fixing title truncation in Metrics Explorer (elastic#55917) (elastic#56248) [APM] x-axis labels on Error occurrences chart are incorrect based on Kibana timezone (elastic#55686) (elastic#56288) Migrate saved_object_save_as_checkbox directive to timelion (elastic#56114) (elastic#56286) [APM] Treat error.exception.stacktrace.line as optional (elastic#55733) (elastic#55840) Remove alerts and actions from feature catalogue (elastic#56140) (elastic#56208) Migrate UI capabilities to use new platform APIs (elastic#56070) (elastic#56207) [ML] Add functional tests for analytics UI: creation addition and regression/outlier results (elastic#56059) (elastic#56191) [SIEM] Overview page feedback (elastic#56261) (elastic#56276) [NP Cleanup] Remove ui/public/inspector (elastic#55677) (elastic#56271) [Index template] Fix editor should support mappings types (elastic#55804) fixes map index message (elastic#56104) (elastic#56194) [SIEM] [TIMELINE] Only add endpoint logo when on event.module === endgame (elastic#56263) (elastic#56269) [SIEM] Fix filters on Hosts and Network page (elastic#56234) (elastic#56267) [SIEM] Adds ability to infer the newsfeed.enabled setting (elastic#56236) (elastic#56265) [SIEM][Detection Engine] critical blocker for updated rules (elastic#56259) [SIEM] Put the notice for rules in comment block (elastic#56123) (elastic#56246) [SIEM][Detection Engine] critical blocker, fixes ordering issue that causes rules to not run the first time (elastic#56256) [Reporting/NP] Migration of Reporting Security dependency (elastic#56046) (elastic#56198) [SIEM] Add link to endpoint app through reference.url (elastic#56211) (elastic#56250) ... # Conflicts: # x-pack/plugins/watcher/public/plugin.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#53898
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibility