Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] [Detections] Cannot go back to "Default blank timeline" for a rule #56520

Merged
merged 1 commit into from
Feb 1, 2020

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Jan 31, 2020

Summary

https://github.com/elastic/siem-team/issues/508

Preconditions:

SIEM prepackaged rules loaded
A duplicated rule with an assigned timeline different from "Default blank timeline"
Steps to reproduce:

  - Go to 'Detections'
  - Go to 'Manage signal detection rules'
  - Go to 'Edit rule settings' of the duplicated rule with the assigned timeline
  - Go to 'About'
  - Expand 'Advanced settings'
  - Select 'Default blank timeline' from 'Investigate detections using this timeline template'
  - Save the changes

Current behaviour:

The change is not saved and the rule is linked to the old timeline.

Expected behaviour:

The change is saved and the rule is linked to the 'Default blank timeline'

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@XavierM XavierM added bug Fixes for quality problems that affect the customer experience critical Team:SIEM v8.0.0 v7.7.0 v7.6.0 labels Jan 31, 2020
@XavierM XavierM self-assigned this Jan 31, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@XavierM XavierM added the release_note:skip Skip the PR/issue when compiling release notes label Jan 31, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out, tested locally and verified this fixes the issue when reverting a duplicated Rule's Timeline Template back to the Default Template. Once saved, the rule now shows Default blank timeline as expected. I also tested the flow where you delete the timeline, and historical signals send to timeline action correctly uses the default blank timeline since it can't find the old timeline.

LGTM! 👍 Thanks @XavierM!

@XavierM XavierM merged commit 7b876c0 into elastic:master Feb 1, 2020
XavierM added a commit to XavierM/kibana that referenced this pull request Feb 1, 2020
@XavierM XavierM mentioned this pull request Feb 1, 2020
XavierM added a commit to XavierM/kibana that referenced this pull request Feb 1, 2020
@XavierM XavierM mentioned this pull request Feb 1, 2020
XavierM added a commit that referenced this pull request Feb 1, 2020
XavierM added a commit that referenced this pull request Feb 1, 2020
jfsiii pushed a commit to jfsiii/kibana that referenced this pull request Feb 4, 2020
@XavierM XavierM deleted the detections-rule-timeline-bugs branch June 4, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience critical release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.6.0 v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants