-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] set filter.meta.key to geoFieldName so query passes filterMatchesIndex when ignoreFilterIfFieldNotInIndex is true #56692
Conversation
Pinging @elastic/kibana-gis (Team:Geo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm from Maps side
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't pulled down, but change to pass in the key looks ok to me
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
…hesIndex when ignoreFilterIfFieldNotInIndex is true (elastic#56692) * [Maps] set filter.meta.key to geoFieldName so query passes filterMatchesIndex * remove unused variable Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
…hesIndex when ignoreFilterIfFieldNotInIndex is true (elastic#56692) * [Maps] set filter.meta.key to geoFieldName so query passes filterMatchesIndex * remove unused variable Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
…hesIndex when ignoreFilterIfFieldNotInIndex is true (#56692) (#57249) * [Maps] set filter.meta.key to geoFieldName so query passes filterMatchesIndex * remove unused variable Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* master: (34 commits) [Index management] Server-side NP ready (elastic#56829) Webhook action - make user and password secrets optional (elastic#56823) [DOCS] Removes reference to IRC (elastic#57245) [Monitoring] NP migration: Local angular module (elastic#51823) [SIEM] Adds ECS link to help menu (elastic#57104) Ensure http interceptors are shares across lifecycle methods (elastic#57150) [Remote clusters] Migrate server code out of legacy (elastic#56781) fixes render bug in alert list (elastic#57152) siem 7.6 updates (elastic#57169) Make the update alert API key API work when AAD is out of sync (elastic#56640) fix(NA): MaxListenersExceededWarning on getLoggerStream (elastic#57133) [Metrics UI] Setup commonly used time ranges in timepicker (elastic#56701) [Maps] set filter.meta.key to geoFieldName so query passes filterMatchesIndex when ignoreFilterIfFieldNotInIndex is true (elastic#56692) Create plugin mock for event log plugin (elastic#57048) fix ts error on master (elastic#57236) Don't create API key for disabled alerts when calling create API (elastic#57041) Fix enable and disable API to still work when AAD is out of sync (elastic#56634) [DOCS] Canvas embed objects (elastic#57156) Delete autocomplete namespace (elastic#57187) Security - Inject logout url (elastic#57201) ...
…hesIndex when ignoreFilterIfFieldNotInIndex is true (#56692) (#57250) * [Maps] set filter.meta.key to geoFieldName so query passes filterMatchesIndex * remove unused variable Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Fixes #56651
When
ignoreFilterIfFieldNotInIndex
is true, queries are removed from the search if the index does not contain the field, https://github.com/elastic/kibana/blob/master/src/plugins/data/common/es_query/es_query/filter_matches_index.ts.The filtering logic looks for
filter.meta.key
to equal one of the field names in the index. The problem was that spatial filters created by the maps application was not setting key to be the geoFieldName. Instead, key was getting set to the top level property likegeo_bounding_box
orgeo_polygon
orgeo_shape
. This PR updates the creation of the spatial filter so that key is set to the geo field name so the mapper does not have to pull it out of the filter where the geoFieldName context has been lost.