Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Fix screenshot pipeline for multi-page #56928

Merged
merged 2 commits into from
Feb 6, 2020

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Feb 5, 2020

Summary

Closes #56182

This fixes a regression bug caused by #48588

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@tsullivan tsullivan added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Feb 5, 2020
@tsullivan tsullivan requested review from joelgriffith and a team February 5, 2020 22:48
Copy link
Contributor

@joelgriffith joelgriffith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Member

@timductive timductive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like unit test is coming in a follow up PR so approving for Canvas team.

@tsullivan tsullivan removed the blocker label Feb 6, 2020
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/rollup_job/tsvb·js.rollup app tsvb integration create rollup tsvb

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/56816

[00:00:00]       │
[00:28:50]         └-: rollup app
[00:28:50]           └-> "before all" hook
[00:30:10]           └-: tsvb integration
[00:30:10]             └-> "before all" hook
[00:30:10]             └-> "before all" hook
[00:30:10]               │ info [visualize/default] Loading "mappings.json"
[00:30:10]               │ info [visualize/default] Loading "data.json"
[00:30:10]               │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-ubuntu-tests-xl-1580944963928131136] [.kibana_1/Zu7xU_Z5QhmXt5ZkGcXAiA] deleting index
[00:30:10]               │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-ubuntu-tests-xl-1580944963928131136] [.kibana_2/2DhtdG-XSuCNtEBia3QS_g] deleting index
[00:30:10]               │ info [visualize/default] Deleted existing index [".kibana_2",".kibana_1"]
[00:30:10]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-tests-xl-1580944963928131136] [.kibana] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:30:10]               │ info [visualize/default] Created index ".kibana"
[00:30:10]               │ debg [visualize/default] ".kibana" settings {"index":{"number_of_shards":"1","auto_expand_replicas":"0-1","number_of_replicas":"0"}}
[00:30:10]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-tests-xl-1580944963928131136] [metricbeat-7] creating index, cause [auto(bulk api)], templates [], shards [1]/[1], mappings []
[00:30:10]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-tests-xl-1580944963928131136] [metricbeat-7/D5H81cBLTmGlBnGuklpFYA] create_mapping
[00:30:10]               │ info [visualize/default] Indexed 8 docs into ".kibana"
[00:30:10]               │ info [visualize/default] Indexed 1 docs into "metricbeat-7"
[00:30:11]               │ info Creating index .kibana_2.
[00:30:11]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-tests-xl-1580944963928131136] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:30:11]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-tests-xl-1580944963928131136] updating number_of_replicas to [0] for indices [.kibana_2]
[00:30:11]               │ info Reindexing .kibana to .kibana_1
[00:30:11]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-tests-xl-1580944963928131136] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:30:11]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-tests-xl-1580944963928131136] updating number_of_replicas to [0] for indices [.kibana_1]
[00:30:11]               │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-ubuntu-tests-xl-1580944963928131136] 68461 finished with response BulkByScrollResponse[took=120ms,timed_out=false,sliceId=null,updated=0,created=8,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:30:12]               │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-ubuntu-tests-xl-1580944963928131136] [.kibana/2Gfo4qD6RcafGtEy1CyJJw] deleting index
[00:30:12]               │ info Migrating .kibana_1 saved objects to .kibana_2
[00:30:12]               │ debg Migrating saved objects space:default, index-pattern:metricbeat-*, custom-space:index-pattern:metricbeat-*, index-pattern:logstash-*, custom_space:index-pattern:logstash-*, visualization:i-exist, custom_space:visualization:i-exist, query:okjpgs
[00:30:12]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-tests-xl-1580944963928131136] [.kibana_2/N-F2bZobRFKArHVnVQUvoQ] update_mapping [_doc]
[00:30:12]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-tests-xl-1580944963928131136] [.kibana_2/N-F2bZobRFKArHVnVQUvoQ] update_mapping [_doc]
[00:30:12]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-tests-xl-1580944963928131136] [.kibana_2/N-F2bZobRFKArHVnVQUvoQ] update_mapping [_doc]
[00:30:12]               │ info Pointing alias .kibana to .kibana_2.
[00:30:12]               │ info Finished in 772ms.
[00:30:12]               │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:30:12]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-tests-xl-1580944963928131136] [.kibana_2/N-F2bZobRFKArHVnVQUvoQ] update_mapping [_doc]
[00:30:13]             └-> create rollup tsvb
[00:30:13]               └-> "before each" hook: global before each
[00:30:13]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-tests-xl-1580944963928131136] [rollup-source-data] creating index, cause [auto(bulk api)], templates [], shards [1]/[1], mappings []
[00:30:13]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-tests-xl-1580944963928131136] [rollup-source-data/pIFj9PgeQN27G09MkFP8uA] create_mapping
[00:30:13]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-tests-xl-1580944963928131136] [rollup-target-data] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:30:13]               │ debg navigating to visualize url: http://localhost:6121/app/kibana#/visualize
[00:30:13]               │ debg Navigate to: http://localhost:6121/app/kibana#/visualize
[00:30:13]               │ info [o.e.x.r.j.RollupJobTask] [kibana-ci-immutable-ubuntu-tests-xl-1580944963928131136] Rollup job [tsvb-test-rollup-job-1580946694821] created.
[00:30:13]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-tests-xl-1580944963928131136] [rollup-target-data/mwkaboFkSMqWONnv-wvMgg] update_mapping [_doc]
[00:30:14]               │ debg ... sleep(700) start
[00:30:14]               │ debg browser[INFO] http://localhost:6121/app/kibana?_t=1580948511242#/visualize 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:30:14]               │
[00:30:14]               │ debg browser[INFO] http://localhost:6121/bundles/app/kibana/bootstrap.js 8:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:30:14]               │ debg ... sleep(700) end
[00:30:14]               │ debg returned from get, calling refresh
[00:30:14]               │ debg browser[INFO] http://localhost:6121/app/kibana?_t=1580948511242#/visualize 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:30:14]               │
[00:30:14]               │ debg browser[INFO] http://localhost:6121/bundles/app/kibana/bootstrap.js 8:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:30:14]               │ debg currentUrl = http://localhost:6121/app/kibana#/visualize
[00:30:14]               │          appUrl = http://localhost:6121/app/kibana#/visualize
[00:30:14]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:30:19]               │ debg TestSubjects.find(kibanaChrome)
[00:30:19]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:30:19]               │ debg browser[INFO] http://localhost:6121/built_assets/dlls/vendors_2.bundle.dll.js 92:138197 "INFO: 2020-02-06T00:21:55Z
[00:30:19]               │        Adding connection to http://localhost:6121/elasticsearch
[00:30:19]               │
[00:30:19]               │      "
[00:30:19]               │ debg ... sleep(501) start
[00:30:19]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-tests-xl-1580944963928131136] [.kibana_2/N-F2bZobRFKArHVnVQUvoQ] update_mapping [_doc]
[00:30:20]               │ debg ... sleep(501) end
[00:30:20]               │ debg in navigateTo url = http://localhost:6121/app/kibana#/visualize?_g=(refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))
[00:30:20]               │ debg TestSubjects.exists(statusPageContainer)
[00:30:20]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:30:22]               │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:30:23]               │ debg TestSubjects.exists(newItemButton)
[00:30:23]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="newItemButton"]') with timeout=2500
[00:30:23]               │ debg TestSubjects.click(newItemButton)
[00:30:23]               │ debg Find.clickByCssSelector('[data-test-subj="newItemButton"]') with timeout=10000
[00:30:23]               │ debg Find.findByCssSelector('[data-test-subj="newItemButton"]') with timeout=10000
[00:30:23]               │ debg TestSubjects.find(visNewDialogTypes)
[00:30:23]               │ debg Find.findByCssSelector('[data-test-subj="visNewDialogTypes"]') with timeout=10000
[00:30:23]               │ debg TestSubjects.click(visType-metrics)
[00:30:23]               │ debg Find.clickByCssSelector('[data-test-subj="visType-metrics"]') with timeout=10000
[00:30:23]               │ debg Find.findByCssSelector('[data-test-subj="visType-metrics"]') with timeout=10000
[00:30:24]               │ debg isGlobalLoadingIndicatorVisible
[00:30:24]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:30:24]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:30:25]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:30:26]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:30:26]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:30:26]               │ debg TestSubjects.exists(tvbVisEditor)
[00:30:26]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="tvbVisEditor"]') with timeout=10000
[00:30:26]               │ debg openQuickSelectTimeMenu
[00:30:26]               │ debg TestSubjects.exists(superDatePickerQuickMenu)
[00:30:26]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerQuickMenu"]') with timeout=2500
[00:30:28]               │ debg --- retry.tryForTime error: [data-test-subj="superDatePickerQuickMenu"] is not displayed
[00:30:29]               │ debg opening quick select menu
[00:30:29]               │ debg TestSubjects.click(superDatePickerToggleQuickMenuButton)
[00:30:29]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerToggleQuickMenuButton"]') with timeout=10000
[00:30:29]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerToggleQuickMenuButton"]') with timeout=10000
[00:30:29]               │ debg TestSubjects.click(superDatePickerCommonlyUsed_Last_24 hours)
[00:30:29]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerCommonlyUsed_Last_24 hours"]') with timeout=10000
[00:30:29]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerCommonlyUsed_Last_24 hours"]') with timeout=10000
[00:30:29]               │ debg TestSubjects.find(metricTsvbTypeBtn)
[00:30:29]               │ debg Find.findByCssSelector('[data-test-subj="metricTsvbTypeBtn"]') with timeout=10000
[00:30:30]               │ debg TestSubjects.exists(tsvbMetricValue)
[00:30:30]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="tsvbMetricValue"]') with timeout=10000
[00:30:30]               │ debg TestSubjects.click(metricEditorPanelOptionsBtn)
[00:30:30]               │ debg Find.clickByCssSelector('[data-test-subj="metricEditorPanelOptionsBtn"]') with timeout=10000
[00:30:30]               │ debg Find.findByCssSelector('[data-test-subj="metricEditorPanelOptionsBtn"]') with timeout=10000
[00:30:30]               │ debg isGlobalLoadingIndicatorVisible
[00:30:30]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:30:30]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:30:32]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:30:32]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:30:32]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:30:32]               │ debg TestSubjects.find(metricsIndexPatternInput)
[00:30:32]               │ debg Find.findByCssSelector('[data-test-subj="metricsIndexPatternInput"]') with timeout=10000
[00:30:33]               │ debg isGlobalLoadingIndicatorVisible
[00:30:33]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:30:33]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:30:34]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:30:35]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:30:35]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:30:35]               │ debg TestSubjects.find(metricsIndexPatternInterval)
[00:30:35]               │ debg Find.findByCssSelector('[data-test-subj="metricsIndexPatternInterval"]') with timeout=10000
[00:30:35]               │ debg isGlobalLoadingIndicatorVisible
[00:30:35]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:30:35]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:30:37]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:30:37]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:30:37]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:30:37]               │ debg TestSubjects.find(metricsDropLastBucket-no)
[00:30:37]               │ debg Find.findByCssSelector('[data-test-subj="metricsDropLastBucket-no"]') with timeout=10000
[00:30:37]               │ debg isGlobalLoadingIndicatorVisible
[00:30:37]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:30:37]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:30:39]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:30:39]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:30:39]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:30:39]               │ debg ... sleep(3000) start
[00:30:42]               │ debg ... sleep(3000) end
[00:30:42]               │ debg Waiting up to 20000ms for rendering count to stabilize...
[00:30:42]               │ debg TestSubjects.find(visualizationLoader)
[00:30:42]               │ debg Find.findByCssSelector('[data-test-subj="visualizationLoader"]') with timeout=10000
[00:30:42]               │ debg -- firstCount=7
[00:30:42]               │ debg ... sleep(1000) start
[00:30:43]               │ debg ... sleep(1000) end
[00:30:43]               │ debg TestSubjects.find(visualizationLoader)
[00:30:43]               │ debg Find.findByCssSelector('[data-test-subj="visualizationLoader"]') with timeout=10000
[00:30:43]               │ debg -- secondCount=7
[00:30:43]               │ debg Find.findByCssSelector('.tvbVisMetric__value--primary') with timeout=10000
[00:30:43]               │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/rollup app tsvb integration create rollup tsvb.png"
[00:30:44]               │ info Current URL is: http://localhost:6121/app/kibana#/visualize/create?type=metrics&_g=(refreshInterval:(pause:!t,value:0),time:(from:now-24h,to:now))&_a=(filters:!(),linked:!f,query:(language:kuery,query:%27%27),uiState:(),vis:(aggs:!(),params:(axis_formatter:number,axis_position:left,axis_scale:normal,background_color_rules:!((id:b54c2ab0-4876-11ea-8499-695a4713da2e)),default_index_pattern:%27metricbeat-*%27,default_timefield:%27@timestamp%27,drop_last_bucket:0,id:%2761ca57f0-469d-11e7-af02-69e470af7417%27,index_pattern:rollup-target-data,interval:%271d%27,isModelInvalid:!f,series:!((axis_position:right,chart_type:line,color:%2368BC00,fill:0.5,formatter:number,id:%2761ca57f1-469d-11e7-af02-69e470af7417%27,line_width:1,metrics:!((id:%2761ca57f2-469d-11e7-af02-69e470af7417%27,type:count)),point_size:1,separate_axis:0,split_mode:everything,stacked:none)),show_grid:1,show_legend:1,time_field:%27%27,type:metric),title:%27%27,type:metrics))
[00:30:44]               │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/rollup app tsvb integration create rollup tsvb.html
[00:30:44]               └- ✖ fail: "rollup app tsvb integration create rollup tsvb"
[00:30:44]               │

Stack Trace

{ Error: expected '0' to sort of equal '3'
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:244:8)
    at Context.it (test/functional/apps/rollup_job/tsvb.js:90:27)
    at process._tickCallback (internal/process/next_tick.js:68:7) actual: '0', expected: '3', showDiff: true }

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan merged commit 9c5d5cb into elastic:master Feb 6, 2020
@tsullivan tsullivan deleted the reporting/fix-multi-url branch February 6, 2020 15:41
tsullivan added a commit to tsullivan/kibana that referenced this pull request Feb 6, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
tsullivan added a commit to tsullivan/kibana that referenced this pull request Feb 6, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
tsullivan added a commit that referenced this pull request Feb 6, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
tsullivan added a commit that referenced this pull request Feb 6, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@tsullivan tsullivan added v7.6.1 and removed v7.6.0 labels Feb 24, 2020
@tsullivan
Copy link
Member Author

Unit test: #57638

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes v7.6.1 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Reporting] Canvas multi-page PDF export doesn't include the entire worksheet
5 participants