Reverting grouped nav UI #57724
Merged
Reverting grouped nav UI #57724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myasonik
added
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-core-ui (Team:Core UI) |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
|
Pining all the teams because I don't think just having the reviewer notifies everyone... Sorry for the spam! @elastic/kibana-platform @elastic/apm-ui @elastic/ml-ui @elastic/kibana-gis @elastic/kibana-app @elastic/kibana-app-arch |
|
@myasonik Thanks for doing this! Would you mind adding some screenshots? I thought I knew what the grouped nav was but that seems to have already been reverted - and not sure what the "previously-known-as-8.0-nav" is. Thanks! |
|
@sqren screenshots added 👍 |
|
ack: will review today |
flash1293
approved these changes
Feb 19, 2020
lizozom
approved these changes
Feb 19, 2020
myasonik
pushed a commit
that referenced
this pull request
Feb 21, 2020
This was referenced Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Grouped nav is cancelled in favor of rolling out the "previously-known-as-8.0-nav" in the 7.x series.
Leaving all the underpinning plumbing in place as the upcoming nav redesign still has groups so the infrastructure for grouping will still be used.
Grouped nav (this was reverted):
Individual nav (the legacy nav, which is the currently the only nav):
"New nav" (planned): #56232
For maintainers