Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Precision function in Timelion Kibana #58031

Merged
merged 4 commits into from
Feb 20, 2020
Merged

Clarify Precision function in Timelion Kibana #58031

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
036c9cb
doc change per issue 26100
rshen91 Feb 19, 2020
8a900ee
update per change requests
rshen91 Feb 19, 2020
d39fd39
remove ja and zh translations
rshen91 Feb 20, 2020
5da7f9b
Merge branch 'master' into tech-writing-change
elasticmachine Feb 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/plugins/timelion/server/series_functions/precision.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ export default new Chainable('precision', {
name: 'precision',
types: ['number'],
help: i18n.translate('timelion.help.functions.precision.args.precisionHelpText', {
defaultMessage: 'Number of digits to round each value to',
defaultMessage: 'The number of digits to truncate each value to',
}),
},
],
help: i18n.translate('timelion.help.functions.precisionHelpText', {
defaultMessage: 'number of digits to round the decimal portion of the value to',
defaultMessage: 'The number of digists to truncate the decimal portion of the value to',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: digists -> digits

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good catch, lol

}),
fn: async function precisionFn(args) {
await alter(args, function(eachSeries, precision) {
Expand Down