Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't mutate error message #58452

Merged
merged 3 commits into from
Feb 25, 2020
Merged

Don't mutate error message #58452

merged 3 commits into from
Feb 25, 2020

Commits on Feb 25, 2020

  1. fix: 🐛 don't mutate error object in-place 

    This avoids mutating error thrown by an expression function in-place.
The error might not even be an object, in which case mutating it will
throw.
    @streamich
    streamich committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    e4634c4 View commit details
    Browse the repository at this point in the history

  2. test: 💍 capture in test that thrown error is not mutated

    @streamich
    streamich committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    eb4f516 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into dont-mutate-error

    @elasticmachine
    elasticmachine authored Feb 25, 2020
    Configuration menu
    Copy the full SHA
    db3d9fc View commit details
    Browse the repository at this point in the history