Bump graphql@14 #58974

patrykkopycinski · 2020-02-29T15:49:13Z

Summary

After #51926 was reverted I've tried to split the changes into smaller pieces and make sure there are stable.
The next step will be #58988

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

patrykkopycinski · 2020-03-01T09:45:28Z

@elasticmachine merge upstream

patrykkopycinski · 2020-03-03T13:15:47Z

@elasticmachine merge upstream

LeeDr · 2020-03-04T15:58:10Z

LGTM - I only pulled the PR locally and verified I could yarn kbn bootstrap and start functional_tests_server from x-pack dir on my local Windows. I checked because there's occasionally a change that breaks Windows. I didn't code review.

patrykkopycinski · 2020-03-05T07:27:58Z

@elasticmachine merge upstream

package.json

packages/kbn-optimizer/src/worker/webpack.config.ts

patrykkopycinski · 2020-03-07T19:05:13Z

@elasticmachine merge upstream

patrykkopycinski · 2020-03-09T15:03:25Z

@elasticmachine merge upstream

spalger

Sweet, thanks for the info and I'm happy to see that removing the nohoist doesn't cause any issues and actually prevents issues as we fiddle a little less with the yarn resolution. LGTM

# Conflicts: # package.json # x-pack/legacy/plugins/siem/public/mock/timeline_results.ts # x-pack/legacy/plugins/siem/public/pages/timelines/timelines_page.tsx # yarn.lock

patrykkopycinski · 2020-04-01T09:48:37Z

x-pack/legacy/plugins/siem/server/lib/framework/kibana_framework_adapter.ts

@@ -89,35 +96,6 @@ export class KibanaBackendFrameworkAdapter implements FrameworkAdapter {
        }
      }
    );
-
-    if (!this.isProductionMode) {


there is no separate endpoint for graphiql anymore

@patrykkopycinski does that mean that this functionality exists within graphql now, or that we're losing this functionality entirely? /cc @XavierM since I know he was most familiar with usage of this endpoint.

cauemarcondes · 2020-04-01T11:44:47Z

.../app/Settings/AgentConfigurations/AgentConfigurationCreateEdit/SettingsPage/SettingsPage.tsx

@@ -38,6 +38,7 @@ import { SettingFormRow } from './SettingFormRow';
 import { getOptionLabel } from '../../../../../../../../../../plugins/apm/common/agent_configuration/all_option';

 function removeEmpty<T>(obj: T): T {
+  // @ts-ignore


Could you add a description of why you're ignoring TS warning, please?

# Conflicts: # yarn.lock

kibanamachine · 2020-04-02T09:16:44Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 701b2d1
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

Test Failures

Kibana Pipeline / kibana-oss-agent / Accessibility Tests.test/accessibility/apps/management·ts.Management Create Index pattern wizard

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 6 times on tracked branches: https://github.com/elastic/kibana/issues/60470

[00:00:00]       │
[00:06:20]         └-: Management
[00:06:20]           └-> "before all" hook
[00:06:20]           └-> "before all" hook
[00:06:20]             │ info [discover] Loading "mappings.json"
[00:06:20]             │ info [discover] Loading "data.json.gz"
[00:06:20]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-oraclelinux-tests-xl-1585813110260599963] [.kibana_1/LzgNupbXQlqNPRx5Zd8WaQ] deleting index
[00:06:20]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-oraclelinux-tests-xl-1585813110260599963] [.kibana_2/Ey74ypxoShSllGetoDKv5Q] deleting index
[00:06:20]             │ info [discover] Deleted existing index [".kibana_2",".kibana_1"]
[00:06:20]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-oraclelinux-tests-xl-1585813110260599963] [.kibana] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:06:20]             │ info [discover] Created index ".kibana"
[00:06:20]             │ debg [discover] ".kibana" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:06:20]             │ info [discover] Indexed 2 docs into ".kibana"
[00:06:20]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-oraclelinux-tests-xl-1585813110260599963] [.kibana/XtfHUzCxQ_mil8zA2pS4NQ] update_mapping [_doc]
[00:06:20]             │ debg Migrating saved objects
[00:06:20]             │ proc [kibana]   log   [08:05:38.343] [info][savedobjects-service] Creating index .kibana_2.
[00:06:20]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-oraclelinux-tests-xl-1585813110260599963] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:06:20]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-oraclelinux-tests-xl-1585813110260599963] updating number_of_replicas to [0] for indices [.kibana_2]
[00:06:20]             │ proc [kibana]   log   [08:05:38.410] [info][savedobjects-service] Reindexing .kibana to .kibana_1
[00:06:20]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-oraclelinux-tests-xl-1585813110260599963] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:06:20]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-oraclelinux-tests-xl-1585813110260599963] updating number_of_replicas to [0] for indices [.kibana_1]
[00:06:20]             │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-oraclelinux-tests-xl-1585813110260599963] 2202 finished with response BulkByScrollResponse[took=25.5ms,timed_out=false,sliceId=null,updated=0,created=2,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:06:21]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-oraclelinux-tests-xl-1585813110260599963] [.kibana/XtfHUzCxQ_mil8zA2pS4NQ] deleting index
[00:06:21]             │ proc [kibana]   log   [08:05:38.761] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:06:21]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-oraclelinux-tests-xl-1585813110260599963] [.kibana_2/QbGWu9IoTmywnWIIaB_ubw] update_mapping [_doc]
[00:06:21]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-oraclelinux-tests-xl-1585813110260599963] [.kibana_2/QbGWu9IoTmywnWIIaB_ubw] update_mapping [_doc]
[00:06:21]             │ proc [kibana]   log   [08:05:38.839] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:06:21]             │ proc [kibana]   log   [08:05:38.871] [info][savedobjects-service] Finished in 529ms.
[00:06:21]             │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:06:21]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-oraclelinux-tests-xl-1585813110260599963] [.kibana_2/QbGWu9IoTmywnWIIaB_ubw] update_mapping [_doc]
[00:06:22]             │ info [logstash_functional] Loading "mappings.json"
[00:06:22]             │ info [logstash_functional] Loading "data.json.gz"
[00:06:22]             │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.22"
[00:06:22]             │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.20"
[00:06:22]             │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.21"
[00:06:24]             │ debg applying update to kibana config: {"defaultIndex":"logstash-*"}
[00:06:24]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-oraclelinux-tests-xl-1585813110260599963] [.kibana_2/QbGWu9IoTmywnWIIaB_ubw] update_mapping [_doc]
[00:06:24]             │ debg navigating to settings url: http://localhost:61131/app/kibana#/management
[00:06:24]             │ debg Navigate to: http://localhost:61131/app/kibana#/management
[00:06:24]             │ debg ... sleep(700) start
[00:06:24]             │ debg browser[INFO] http://localhost:61131/app/kibana?_t=1585814742417#/management 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:06:24]             │
[00:06:24]             │ debg browser[INFO] http://localhost:61131/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:06:25]             │ debg ... sleep(700) end
[00:06:25]             │ debg returned from get, calling refresh
[00:06:25]             │ debg browser[INFO] http://localhost:61131/app/kibana?_t=1585814742417#/management 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:06:25]             │
[00:06:25]             │ debg browser[INFO] http://localhost:61131/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:06:26]             │ debg currentUrl = http://localhost:61131/app/kibana#/management
[00:06:26]             │          appUrl = http://localhost:61131/app/kibana#/management
[00:06:26]             │ debg TestSubjects.find(kibanaChrome)
[00:06:26]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:06:28]             │ debg TestSubjects.find(kibanaChrome)
[00:06:28]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:06:28]             │ debg browser[INFO] http://localhost:61131/bundles/plugin/data/data.plugin.js 96:139630 "INFO: 2020-04-02T08:05:45Z
[00:06:28]             │        Adding connection to http://localhost:61131/elasticsearch
[00:06:28]             │
[00:06:28]             │      "
[00:06:28]             │ debg ... sleep(501) start
[00:06:28]             │ debg ... sleep(501) end
[00:06:28]             │ debg in navigateTo url = http://localhost:61131/app/kibana#/management?_g=()
[00:06:28]             │ debg TestSubjects.exists(statusPageContainer)
[00:06:28]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:06:31]             │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:06:31]           └-> main view
[00:06:31]             └-> "before each" hook: global before each
[00:06:32]             └- ✓ pass  (379ms) "Management main view"
[00:06:32]           └-> index pattern page
[00:06:32]             └-> "before each" hook: global before each
[00:06:32]             │ debg clickKibanaIndexPatterns link
[00:06:32]             │ debg TestSubjects.click(index_patterns)
[00:06:32]             │ debg Find.clickByCssSelector('[data-test-subj="index_patterns"]') with timeout=10000
[00:06:32]             │ debg Find.findByCssSelector('[data-test-subj="index_patterns"]') with timeout=10000
[00:06:32]             │ debg isGlobalLoadingIndicatorVisible
[00:06:32]             │ debg TestSubjects.exists(globalLoadingIndicator)
[00:06:32]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:06:32]             │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:06:34]             │ debg --- retry.tryForTime failed again with the same message...
[00:06:35]             │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:06:35]             │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:06:35]             │ debg Waiting up to 20000ms for index pattern info flyout...
[00:06:35]             │ debg TestSubjects.exists(CreateIndexPatternPrompt)
[00:06:35]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="CreateIndexPatternPrompt"]') with timeout=2500
[00:06:37]             │ debg --- retry.tryForTime error: [data-test-subj="CreateIndexPatternPrompt"] is not displayed
[00:06:38]             └- ✓ pass  (6.1s) "Management index pattern page"
[00:06:38]           └-> Single indexpattern view
[00:06:38]             └-> "before each" hook: global before each
[00:06:38]             │ debg Find.byXPath('//a[descendant::*[text()='logstash-*']]') with timeout=10000
[00:06:38]             └- ✓ pass  (397ms) "Management Single indexpattern view"
[00:06:38]           └-> Create Index pattern wizard
[00:06:38]             └-> "before each" hook: global before each
[00:06:38]             │ debg clickKibanaIndexPatterns link
[00:06:38]             │ debg TestSubjects.click(index_patterns)
[00:06:38]             │ debg Find.clickByCssSelector('[data-test-subj="index_patterns"]') with timeout=10000
[00:06:38]             │ debg Find.findByCssSelector('[data-test-subj="index_patterns"]') with timeout=10000
[00:06:39]             │ debg isGlobalLoadingIndicatorVisible
[00:06:39]             │ debg TestSubjects.exists(globalLoadingIndicator)
[00:06:39]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:06:40]             │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:06:41]             │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:06:41]             │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:06:41]             │ debg Waiting up to 20000ms for index pattern info flyout...
[00:06:41]             │ debg TestSubjects.exists(CreateIndexPatternPrompt)
[00:06:41]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="CreateIndexPatternPrompt"]') with timeout=2500
[00:06:43]             │ debg --- retry.tryForTime error: [data-test-subj="CreateIndexPatternPrompt"] is not displayed
[00:06:44]             │ debg TestSubjects.find(createIndexPatternButton)
[00:06:44]             │ debg Find.findByCssSelector('[data-test-subj="createIndexPatternButton"]') with timeout=10000
[00:06:54]             │ info Taking screenshot "/dev/shm/workspace/kibana/test/functional/screenshots/failure/Management Create Index pattern wizard.png"
[00:06:54]             │ info Current URL is: http://localhost:61131/app/kibana#/management/kibana/index_patterns/logstash-*?_g=()&_a=(tab:indexedFields)
[00:06:54]             │ info Saving page source to: /dev/shm/workspace/kibana/test/functional/failure_debug/html/Management Create Index pattern wizard.html
[00:06:54]             └- ✖ fail: "Management Create Index pattern wizard"
[00:06:54]             │

Stack Trace

{ TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="createIndexPatternButton"])
Wait timed out after 10024ms
    at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:841:17
    at process._tickCallback (internal/process/next_tick.js:68:7) name: 'TimeoutError', remoteStacktrace: '' }

History

💚 Build #37772 succeeded 8b15e3a
💔 Build #37577 failed 575591a
💚 Build #32151 succeeded d1c0611
💛 Build #31782 was flaky bf41418
💚 Build #31643 succeeded 6e29fa3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

patrykkopycinski added 3 commits February 29, 2020 16:00

Bump graphql@14

10ce1bf

types

7d18f7d

fix types

c5e1680

patrykkopycinski requested review from a team as code owners February 29, 2020 15:49

patrykkopycinski self-assigned this Feb 29, 2020

patrykkopycinski added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0 labels Feb 29, 2020

patrykkopycinski added 3 commits February 29, 2020 17:09

renovate

1d219b5

info

d01e64e

cleanup

38f40dc

Merge branch 'master' into chore/graphql-14

f760b47

patrykkopycinski mentioned this pull request Mar 1, 2020

Bump react-apollo@3 #58988

Closed

7 tasks

patrykkopycinski requested review from spalger, tylersmalley and LeeDr March 1, 2020 13:23

Merge branch 'master' into chore/graphql-14

28e6b07

Merge branch 'master' into chore/graphql-14

92d8b62

spalger reviewed Mar 6, 2020

View reviewed changes

package.json Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

packages/kbn-optimizer/src/worker/webpack.config.ts Show resolved Hide resolved

elasticmachine and others added 2 commits March 7, 2020 14:05

Merge branch 'master' into chore/graphql-14

bea7629

update package.json

6e29fa3

elasticmachine and others added 2 commits March 9, 2020 11:03

Merge branch 'master' into chore/graphql-14

bf41418

Merge branch 'master' of github.com:elastic/kibana into pr/58974

d1c0611

spalger approved these changes Mar 10, 2020

View reviewed changes

patrykkopycinski added v7.8.0 and removed v7.7.0 labels Mar 12, 2020

Merge branch 'master' of github.com:elastic/kibana into chore/graphql-14

575591a

# Conflicts: # package.json # x-pack/legacy/plugins/siem/public/mock/timeline_results.ts # x-pack/legacy/plugins/siem/public/pages/timelines/timelines_page.tsx # yarn.lock

patrykkopycinski requested a review from a team as a code owner March 31, 2020 16:36

patrykkopycinski added 3 commits April 1, 2020 09:44

Merge branch 'master' of github.com:elastic/kibana into chore/graphql-14

9681521

Merge branch 'master' of github.com:elastic/kibana into chore/graphql-14

ce7d804

udpate tests

8b15e3a

patrykkopycinski requested a review from a team as a code owner April 1, 2020 09:43

patrykkopycinski commented Apr 1, 2020

View reviewed changes

cauemarcondes reviewed Apr 1, 2020

View reviewed changes

Merge branch 'master' of github.com:elastic/kibana into chore/graphql-14

701b2d1

# Conflicts: # yarn.lock

patrykkopycinski closed this Apr 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump graphql@14 #58974

Bump graphql@14 #58974

patrykkopycinski commented Feb 29, 2020 •

edited

Loading

patrykkopycinski commented Mar 1, 2020

patrykkopycinski commented Mar 3, 2020

LeeDr commented Mar 4, 2020

patrykkopycinski commented Mar 5, 2020

patrykkopycinski commented Mar 7, 2020

patrykkopycinski commented Mar 9, 2020

spalger left a comment

patrykkopycinski Apr 1, 2020

rylnd Apr 1, 2020

cauemarcondes Apr 1, 2020

kibanamachine commented Apr 2, 2020

Standard Out

Stack Trace

Bump graphql@14 #58974

Bump graphql@14 #58974

Conversation

patrykkopycinski commented Feb 29, 2020 • edited Loading

Summary

Checklist

For maintainers

patrykkopycinski commented Mar 1, 2020

patrykkopycinski commented Mar 3, 2020

LeeDr commented Mar 4, 2020

patrykkopycinski commented Mar 5, 2020

patrykkopycinski commented Mar 7, 2020

patrykkopycinski commented Mar 9, 2020

spalger left a comment

Choose a reason for hiding this comment

patrykkopycinski Apr 1, 2020

Choose a reason for hiding this comment

rylnd Apr 1, 2020

Choose a reason for hiding this comment

cauemarcondes Apr 1, 2020

Choose a reason for hiding this comment

kibanamachine commented Apr 2, 2020

💔 Build Failed

Failed CI Steps

Test Failures

Standard Out

Stack Trace

History

patrykkopycinski commented Feb 29, 2020 •

edited

Loading