-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Time Range in Vis State #59220
Fix Time Range in Vis State #59220
Conversation
… useEffect for timeRange changes, and an action & reducer to capture those changes. Added timeRange to createAggConfigs, and used the setTimeRange method in createAggConfigs
Pinging @elastic/kibana-app (Team:KibanaApp) |
Seems like it's overlapping with #59171 @ThomThomson the history says you assigned and directly unassigned the underlying issue (#57822), was this a mistake? |
@flash1293 I unassigned myself from the issue when @timroes identified that it was a symptom of an architectural problem. He later showed me which files to look into and gave me some instructions, so this PR is mostly for my learning. That said, the overlap is my bad! We are planning to look into it tomorrow. |
I am sorry, that confusion was on me, we should not have unassigned ourselves from that. I've closed the other PR, and reassigned the issue, sorry everyone, mea culpa! |
💔 Build FailedTest FailuresKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/visualize/_linked_saved_searches·ts.visualize app visualize app linked saved searched should not break when saving after unlinkingStandard Out
Stack Trace
Kibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/dashboard/create_and_add_embeddables·js.dashboard app using current data create and add embeddables add new visualization link adds a new visualizationStandard Out
Stack Trace
Kibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/dashboard/create_and_add_embeddables·js.dashboard app using current data create and add embeddables add new visualization link adds a new visualizationStandard Out
Stack Trace
and 6 more failures, only showing the first 3. To update your PR or re-run it, just comment with: |
Summary
Added an action & reducer for when the timeRange changes. This uses 'createAggConfigs' and the existing setTimeRange method on the AggConfigs type to make the current timeRange accessible by date_histogram and other agg types.
This change allows the interval scaling message to show up when the selected interval would create too many buckets:
It also fixes the label when the interval is set 'auto' and the date histogram is minimized:
Closes #57822
Checklist
Delete any items that are not applicable to this PR.
For maintainers