Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alerting update route throttle property is missing #59580

Merged
merged 5 commits into from
Mar 7, 2020
Merged

Alerting update route throttle property is missing #59580

merged 5 commits into from
Mar 7, 2020

Conversation

YulNaumenko
Copy link
Contributor

No description provided.

@YulNaumenko
Added throttle property to update method of alertClient
9bac69f
@YulNaumenko
Merge remote-tracking branch 'upstream/master' into alerting-update-r…
7a80278 
…oute-throttle-missing

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@YulNaumenko YulNaumenko added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Mar 6, 2020
@YulNaumenko YulNaumenko requested a review from a team as a code owner March 6, 2020 18:51
@YulNaumenko YulNaumenko self-assigned this Mar 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

mikecote
mikecote approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pmuellr
pmuellr reviewed Mar 6, 2020
View reviewed changes
x-pack/legacy/plugins/siem/server/lib/detection_engine/rules/patch_rules.ts Outdated
@@ -108,6 +108,7 @@ export const patchRules = async ({
id: rule.id,
data: {
tags: addTags(tags ?? rule.tags, rule.params.ruleId, immutable ?? rule.params.immutable),
throttle: null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will overwrite whatever value was previously stored. Do they always use null for throttle?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! I will fix it based on siem proposal.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if you can pass undefined, and make use of elasticsearch partial update - this gets complicated when we use schema-config, and ESO's. Ugggh.

pmuellr
pmuellr approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except worried about the SIEM code that's setting throttle: null in the update, it will erase whatever throttle they had previously set.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@YulNaumenko YulNaumenko merged commit b960c6a into elastic:master Mar 7, 2020
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Mar 7, 2020
@YulNaumenko
Alerting update route throttle property is missing (elastic#59580)
79593cd 
* Added throttle property to update method of alertClient

* Fixed failing snapshot

* Fixed type check errors

* Fixed null update for siem throttle
@YulNaumenko YulNaumenko mentioned this pull request Mar 7, 2020
Merged
YulNaumenko added a commit that referenced this pull request Mar 7, 2020
@YulNaumenko
Alerting update route throttle property is missing (#59580) (#59606)
2b04142 
* Added throttle property to update method of alertClient

* Fixed failing snapshot

* Fixed type check errors

* Fixed null update for siem throttle
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 9, 2020
@gmmorris
Merge branch 'master' into alerting/view-in-app
57d5b4f 
* master: (154 commits)
  Add an optional authentication mode for HTTP resources (elastic#58589)
  Implement embeddable drilldown menu options (elastic#59232)
  [Alerting] "Create alert" graph visualization design improvements (elastic#59399)
  Alerting update route throttle property is missing (elastic#59580)
  [SIEM] Adds 'Load prebuilt rules' Cypress test (elastic#59529)
  Show error if field is not found during filter rendering (elastic#59298)
  Navigate back to discover app during test, because the saved search from the preceding test has major performance problems when used with this test (elastic#59571)
  Check for alert dialog when doing a force logout (elastic#59329)
  ensure fs deletes are not cwd dependent (elastic#59570)
  Empty message for APM service map (elastic#59518)
  [Drilldowns] <ActionWizard/> Component (elastic#59032)
  [Reporting] Improve the page exit error messages (elastic#59351)
  Ensure logged out starting state for tests that need it (elastic#59322)
  Hide input value from kbn-config-schema error messages (elastic#58843)
  [ML] Transforms: Migrate client plugin to NP. (elastic#59443)
  [ML] Disable failing functional tests
  [SIEM] Update Timeline to use the latest euiFlyoutBody style (elastic#59524)
  Temporarily remove the project mappings for PR labels (elastic#59493)
  [Alerting] replace index threshold graph usage of watcher APIs with new API (elastic#59385)
  [ML] Show view series link in anomalies table for machine_learning_user role (elastic#59549)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuellr pmuellr pmuellr approved these changes

@mikecote mikecote mikecote approved these changes

Assignees

@YulNaumenko YulNaumenko

Labels
Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@YulNaumenko @elasticmachine @kibanamachine @pmuellr @mikecote