Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM][CASE] Change configuration button #60229

Merged
merged 2 commits into from
Mar 16, 2020
Merged

[SIEM][CASE] Change configuration button #60229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e74c7f8
Change button
cnasikas Mar 16, 2020
ad74b02
Make URLs constants
cnasikas Mar 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions x-pack/legacy/plugins/siem/public/pages/case/components/all_cases/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import React, { useCallback, useEffect, useMemo, useState } from 'react';
import {
EuiBasicTable,
EuiButton,
EuiButtonIcon,
EuiContextMenuPanel,
EuiEmptyPrompt,
EuiFlexGroup,
Expand Down Expand Up @@ -45,6 +44,9 @@ import { OpenClosedStats } from '../open_closed_stats';
import { getActions } from './actions';
import { CasesTableFilters } from './table_filters';

const CONFIGURE_CASES_URL = getConfigureCasesUrl();
const CREATE_CASE_URL = getCreateCaseUrl();

const Div = styled.div`
margin-top: ${({ theme }) => theme.eui.paddingSizes.m};
`;
Expand Down Expand Up @@ -259,16 +261,14 @@ export const AllCases = React.memo(() => {
/>
</FlexItemDivider>
<EuiFlexItem grow={false}>
<EuiButton fill href={getCreateCaseUrl()} iconType="plusInCircle">
cnasikas marked this conversation as resolved.
Show resolved Hide resolved
{i18n.CREATE_TITLE}
<EuiButton href={CONFIGURE_CASES_URL} iconType="controlsHorizontal">
{i18n.CONFIGURE_CASES_BUTTON}
</EuiButton>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButtonIcon
aria-label={i18n.CONFIGURE_CASES_BUTTON}
href={getConfigureCasesUrl()}
iconType="gear"
/>
<EuiButton fill href={CREATE_CASE_URL} iconType="plusInCircle">
{i18n.CREATE_TITLE}
</EuiButton>
</EuiFlexItem>
</EuiFlexGroup>
</CaseHeaderPage>
Expand Down Expand Up @@ -325,7 +325,7 @@ export const AllCases = React.memo(() => {
titleSize="xs"
body={i18n.NO_CASES_BODY}
actions={
<EuiButton fill size="s" href={getCreateCaseUrl()} iconType="plusInCircle">
<EuiButton fill size="s" href={CREATE_CASE_URL} iconType="plusInCircle">
{i18n.ADD_NEW_CASE}
</EuiButton>
}
Expand Down
2 changes: 1 addition & 1 deletion x-pack/legacy/plugins/siem/public/pages/case/translations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export const CONFIGURE_CASES_PAGE_TITLE = i18n.translate(
);

export const CONFIGURE_CASES_BUTTON = i18n.translate('xpack.siem.case.configureCasesButton', {
defaultMessage: 'Configure cases',
defaultMessage: 'Edit third-party connection',
});

export const ADD_COMMENT = i18n.translate('xpack.siem.case.caseView.comment.addComment', {
Expand Down