-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NP] Remove ui/agg_types
dependencies and move paginated table to kibana_legacy
#60276
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
7eed77e
fix agg type shims and move paginated table to kibana_legacy
flash1293 3e992c2
Merge remote-tracking branch 'upstream/master' into fix-visualize-shims
flash1293 f880e2d
fix types
flash1293 7abddc4
fix i18n ids
flash1293 555e19e
fix unit tests
flash1293 d70fac3
Merge remote-tracking branch 'upstream/master' into fix-visualize-shims
flash1293 94f8f84
Merge branch 'master' into fix-visualize-shims
sulemanof f390d01
Update imports
sulemanof d4688bf
Remove ui/agg_types imports
sulemanof 97f40f4
Clean up vis_default_editor plugin
sulemanof 111d502
Remove agg_types imports in vis_type_table
sulemanof 7a9b879
Clean up x-pack
sulemanof 87bc3dc
Clean up vis_type_vislib
sulemanof bbd5256
Last cleanups
sulemanof 1d0cb79
Merge remote-tracking branch 'upstream/master' into fix-visualize-shims
sulemanof fc3c455
Update docs
sulemanof 895c69b
Merge remote-tracking branch 'upstream/master' into fix-visualize-shims
sulemanof b68ab0b
Mock Schemas in vis_type_metric
sulemanof 7c358a9
Use data plugin mocks
sulemanof b258b21
Remove ui/directives/paginate reference
sulemanof 79b7b88
Merge remote-tracking branch 'upstream/master' into fix-visualize-shims
sulemanof 937777f
Remove snapshot
sulemanof 57ea6fa
Remove shallow
sulemanof 40c15a0
Merge branch 'master' into fix-visualize-shims
elasticmachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no necessity to collect coverage from these folders (
agg_types
doesn't exist anymore,vis
contains only legacy mocka tests since the most of code was moved)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍