Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest] Refactor to use new top-level PackageIcon component #60628

Merged
merged 1 commit into from
Mar 19, 2020
Merged

[Ingest] Refactor to use new top-level PackageIcon component #60628

merged 1 commit into from
Mar 19, 2020

Conversation

paul-tavares
Copy link
Contributor

Summary

Removes the PackageIcon component currently under epm section and refactors usages of it to instead use the new top-level PackageIcon.

closes #60435

Checklist

checked the following screens to ensure Icons are displayed correctly

  • EPM packages page - all packages tab + installed packages tab
  • create datasource flow - select package step
  • Agent config details, datasources list

@paul-tavares paul-tavares added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project v7.7.0 labels Mar 19, 2020
@paul-tavares paul-tavares requested a review from a team March 19, 2020 14:05
@paul-tavares paul-tavares self-assigned this Mar 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Feature:EPM)

@hbharding
Copy link
Contributor

We're calling "packages" "integrations" now as per https://github.com/elastic/observability-dev/issues/659. Perhaps we could rename this to IntegrationIcon. I'm not sure if there are other places in the code where we use the word "package", and if we want to be consistent and keep "packages" in the codebase for now, or rather start making these changes now (incrementally).

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jen-huang
jen-huang approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! +1 on sticking with "Package"Icon for naming

@jen-huang jen-huang mentioned this pull request Mar 19, 2020
Closed
22 tasks
@paul-tavares paul-tavares merged commit 58b7e20 into elastic:master Mar 19, 2020
@paul-tavares paul-tavares deleted the task/ingest-60435-package-icon branch March 19, 2020 18:38
@paul-tavares paul-tavares mentioned this pull request Mar 19, 2020
Merged
paul-tavares added a commit that referenced this pull request Mar 20, 2020
@paul-tavares
Refactor to use new top-level PackageIcon component (#60628) (#60671)
546ad07 
- removes PackageIcon from EPM section
- refactors code to use new top-level `PackageIcon` component
@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jen-huang jen-huang jen-huang approved these changes

Assignees

@paul-tavares paul-tavares

Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Ingest] Add ability to serve/retrieve a Package's Icon for display on the UI
5 participants
@paul-tavares @elasticmachine @hbharding @kibanamachine @jen-huang