Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate test plugins ⇒ NP (kbn_tp_sample_panel_action) #60749

Merged
merged 5 commits into from
Apr 1, 2020
Merged

Migrate test plugins ⇒ NP (kbn_tp_sample_panel_action) #60749

merged 5 commits into from
Apr 1, 2020

Conversation

VladLasitsa
Copy link
Contributor

Part of #51275

Summary

  • kbn_tp_sample_panel_action - actions demo

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@VladLasitsa VladLasitsa requested a review from alexwizp March 20, 2020 13:22
@VladLasitsa VladLasitsa self-assigned this Mar 20, 2020
@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

merge conflict between base and head

@VladLasitsa VladLasitsa force-pushed the migrate_test_plugin_sample_action_to_np branch from 86a6387 to 0d0297c Compare March 23, 2020 09:03
alexwizp
alexwizp approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lizozom lizozom mentioned this pull request Mar 24, 2020
Closed
6 tasks
@alexwizp
Copy link
Contributor

Could you please replace the plugin name in all places
image

@VladLasitsa
Copy link
Contributor Author

Could you please replace the plugin name in all places
image

done

@VladLasitsa VladLasitsa changed the title Migrate test plugins ⇒ NP Migrate test plugins ⇒ NP (kbn_tp_sample_panel_action) Mar 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@VladLasitsa VladLasitsa marked this pull request as ready for review March 26, 2020 09:43
@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

ppisljar
ppisljar approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@VladLasitsa VladLasitsa merged commit 5d5c012 into elastic:master Apr 1, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 1, 2020
@gmmorris
Merge branch 'master' into event-log/query-support
7805cc1 
* master: (44 commits)
  [Alerting] add alerting privileges for uptime and metrics (elastic#61113)
  Update percy agent to latest version (elastic#62089)
  [APM] Update central configuration text (elastic#61556)
  [Fleet] Ouput api key do not need metricbeat* access (elastic#60319)
  Document new `xpack.security.authc.*` settings and related 8.0.0 breaking changes. (elastic#61443)
  Migrate test plugins ⇒ NP (kbn_tp_sample_panel_action) (elastic#60749)
  [Alerting] Add "Start trial" button for connectors (elastic#61774)
  [ML] Transforms: Fix handling of default and advanced search on step summary view. (elastic#61799)
  [Task Manager] Change info message "ran out Available Workers" to debug (elastic#62083)
  [Maps] Highlight selected layer in TOC (elastic#61510)
  ensure pageIndex is set correclty in analytics list (elastic#62041)
  [ML] Functional API tests - fix mml request bodies (elastic#62116)
  Fix validation for index threshold when selecting an index (elastic#61615)
  [SIEM][Detection Engine] Adds release notes link and updates one UI section
  [backport] Bump to 5.1.2 (elastic#62117)
  [APM] .apm-agent-configuration is not created if Kibana is started while ES is not ready (elastic#61610)
  [Fleet] Enrollment list page (elastic#61346)
  [ML] Fix maximum default enabled columns for data grid. (elastic#62005)
  [Home][Tutorial] Add Oracle data UI (elastic#61595)
  [APM] Ensure telemetry data matches SO/telemetry mapping (elastic#61957)
  ...
VladLasitsa added a commit to VladLasitsa/kibana that referenced this pull request Apr 2, 2020
@VladLasitsa @elasticmachine
Migrate test plugins ⇒ NP (kbn_tp_sample_panel_action) (elastic#60749)
038242b 
* Migrated sample_action to NP. Panel action tests returned to the test flow.

* fixed names

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@VladLasitsa VladLasitsa mentioned this pull request Apr 2, 2020
Closed
@VladLasitsa VladLasitsa mentioned this pull request Apr 2, 2020
Merged
VladLasitsa added a commit to VladLasitsa/kibana that referenced this pull request Apr 2, 2020
@VladLasitsa @elasticmachine
Migrate test plugins ⇒ NP (kbn_tp_sample_panel_action) (elastic#60749)
52ee957 
* Migrated sample_action to NP. Panel action tests returned to the test flow.

* fixed names

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
VladLasitsa added a commit that referenced this pull request Apr 2, 2020
@VladLasitsa @elasticmachine
Migrate test plugins ⇒ NP (kbn_tp_sample_panel_action) (#60749) (#62315)
4c7ad1f 
* Migrated sample_action to NP. Panel action tests returned to the test flow.

* fixed names

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexwizp alexwizp alexwizp approved these changes

@ppisljar ppisljar ppisljar approved these changes

@lizozom lizozom Awaiting requested review from lizozom

@lukeelmers lukeelmers Awaiting requested review from lukeelmers

Assignees

@VladLasitsa VladLasitsa

Labels
Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VladLasitsa @elasticmachine @alexwizp @kibanamachine @ppisljar