Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Allow edits to jobs with additional custom_settings props #61067

Merged
merged 3 commits into from
Mar 24, 2020
Merged

[ML] Allow edits to jobs with additional custom_settings props #61067

merged 3 commits into from
Mar 24, 2020

Conversation

peteharverson
Copy link
Contributor

Summary

Fixes error saving edits to a job where the custom_settings field contains properties other than created_by or custom_urls, following #56717 where validation was added to the anomaly_detectors server routes. For example, the jobs in the Logs UI modules contain a job_revision property in custom_settings which meant previously edits to the job, such as to the datafeed or job description could not be saved.

Fixes #60640

@peteharverson peteharverson added review non-issue Indicates to automation that a pull request should not appear in the release notes :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 24, 2020
@peteharverson peteharverson requested a review from a team as a code owner March 24, 2020 13:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alvarezmelissa87
alvarezmelissa87 approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@peteharverson peteharverson merged commit a68eaf2 into elastic:master Mar 24, 2020
@peteharverson peteharverson deleted the ml-job-custom-settings-schema branch March 24, 2020 20:18
@peteharverson peteharverson mentioned this pull request Mar 24, 2020
Merged
peteharverson added a commit that referenced this pull request Mar 25, 2020
@peteharverson @elasticmachine
[ML] Allow edits to jobs with additional custom_settings props (#61067)…
e3c4048 
… (#61156)

* [ML] Allow edits to jobs with additional custom_settings props

* [ML] Minor text edit

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@walterra walterra Awaiting requested review from walterra

@darnautov darnautov Awaiting requested review from darnautov

@jgowdyelastic jgowdyelastic Awaiting requested review from jgowdyelastic

Assignees
No one assigned
Labels
Feature:Anomaly Detection ML anomaly detection :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Error editing a Logs UI job where custom_settings contains job_revision property
4 participants
@peteharverson @elasticmachine @kibanamachine @alvarezmelissa87