[SIEM][CASE] Configuration page tests #61093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
added
release_note:skip
|
Pinging @elastic/siem (Team:SIEM) |
cnasikas
force-pushed
the
configuration_page_tests
branch
3 times, most recently
from
a734b88 to
bca2bdc
Compare
26 tasks
cnasikas
force-pushed
the
configuration_page_tests
branch
5 times, most recently
from
d03594c to
418407a
Compare
cnasikas
changed the title
cnasikas
force-pushed
the
configuration_page_tests
branch
from
418407a to
fcf0836
Compare
cnasikas
changed the title
|
@elasticmachine merge upstream |
|
Please be aware that x-pack/legacy/plugins/siem/public/pages/case/components/configure_cases/index.test.tsx is big and Github does not showing it fully. |
cnasikas
requested review from
angorayc,
yctercero,
andrew-goldstein and
FrankHassanabad
angorayc
reviewed
Apr 3, 2020
x-pack/legacy/plugins/siem/public/pages/case/components/configure_cases/index.test.tsx
Outdated
Show resolved
Hide resolved
angorayc
reviewed
Apr 3, 2020
|
|
||
| beforeEach(() => { | ||
| jest.resetAllMocks(); | ||
| useCaseConfigureMock.mockImplementation( |
There was a problem hiding this comment.
In comparison to mock the implementation here, I would mock the return value for useCaseConfigureMock and useReducer
In this case for example, I would remove Line 74-83, and add a mockReturnValue for useReducer.
There was a problem hiding this comment.
I would like to avoid mocking the reducer because is a pure function and this is the only way (in my knowledge) I can test the callback functions (setConnectorId etc).
angorayc
reviewed
Apr 3, 2020
x-pack/legacy/plugins/siem/public/pages/case/components/configure_cases/index.test.tsx
Outdated
Show resolved
Hide resolved
angorayc
reviewed
Apr 3, 2020
x-pack/legacy/plugins/siem/public/pages/case/components/configure_cases/index.test.tsx
Show resolved
Hide resolved
angorayc
reviewed
Apr 3, 2020
x-pack/legacy/plugins/siem/public/pages/case/components/configure_cases/index.test.tsx
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
Apr 6, 2020
* Test ClosureOptionsRadio component * Test ClosureOptions component * Test ConnectorsDropdown component * Test Connectors * Test FieldMappingRow * Test FieldMapping * Create utils functions and refactor to be able to test * Test Mapping * Improve tests * Test ConfigureCases * Refactor tests * Fix flacky tests * Remove snapshots * Refactor tests * Test button * Test reducer * Move test * Better structure Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
Apr 6, 2020
* Test ClosureOptionsRadio component * Test ClosureOptions component * Test ConnectorsDropdown component * Test Connectors * Test FieldMappingRow * Test FieldMapping * Create utils functions and refactor to be able to test * Test Mapping * Improve tests * Test ConfigureCases * Refactor tests * Fix flacky tests * Remove snapshots * Refactor tests * Test button * Test reducer * Move test * Better structure Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
cnasikas
added a commit
that referenced
this pull request
Apr 6, 2020
* Test ClosureOptionsRadio component * Test ClosureOptions component * Test ConnectorsDropdown component * Test Connectors * Test FieldMappingRow * Test FieldMapping * Create utils functions and refactor to be able to test * Test Mapping * Improve tests * Test ConfigureCases * Refactor tests * Fix flacky tests * Remove snapshots * Refactor tests * Test button * Test reducer * Move test * Better structure Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
cnasikas
added a commit
that referenced
this pull request
Apr 6, 2020
* Test ClosureOptionsRadio component * Test ClosureOptions component * Test ConnectorsDropdown component * Test Connectors * Test FieldMappingRow * Test FieldMapping * Create utils functions and refactor to be able to test * Test Mapping * Improve tests * Test ConfigureCases * Refactor tests * Fix flacky tests * Remove snapshots * Refactor tests * Test button * Test reducer * Move test * Better structure Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test for the configuration page (#61092).
Checklist
Delete any items that are not applicable to this PR.
For maintainers