Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] [Cases] Final case features for 7.7 #61161

Merged
merged 9 commits into from
Mar 25, 2020
Merged

[SIEM] [Cases] Final case features for 7.7 #61161

merged 9 commits into from
Mar 25, 2020

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Mar 24, 2020 •
edited
Loading

Final Features for Case

Completes the final feature requests for case in 7.7

Screen Shot 2020-03-24 at 2 23 50 PM

Follow up

2 things I'd like to improve on but let's merge it first unless someone knows a quick way on the second item?

  1. no new line (blank line) with this markdown component. maybe we should switch?
  2. I want the text area to get focus when the quote happens

@stephmilovic stephmilovic added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 24, 2020
@stephmilovic stephmilovic requested a review from a team as a code owner March 24, 2020 20:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@stephmilovic stephmilovic changed the title last case features [SIEM] [Cases] Final case features for 7.7 Mar 24, 2020
@stephmilovic stephmilovic mentioned this pull request Mar 24, 2020
Closed
26 tasks
@XavierM
Copy link
Contributor

XavierM commented Mar 24, 2020

image
Can we have the reply quote not centered but left align?

@XavierM
Copy link
Contributor

XavierM commented Mar 24, 2020

image

Can we had the incident name with the link to incident platform? All this information is under external_service

XavierM
XavierM approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -> we can take care of the rest loading in a follow-up PR

@stephmilovic
Copy link
Contributor Author

stephmilovic commented Mar 25, 2020 •
edited
Loading

One last change for Prince @XavierM
prince
jk one more:
Screen Shot 2020-03-24 at 7 02 33 PM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stephmilovic stephmilovic merged commit 1e3c5b1 into elastic:master Mar 25, 2020
@stephmilovic stephmilovic deleted the last-case-features branch March 25, 2020 05:39
@stephmilovic stephmilovic mentioned this pull request Mar 25, 2020
Merged
stephmilovic added a commit to stephmilovic/kibana that referenced this pull request Mar 25, 2020
@stephmilovic
[SIEM] [Cases] Final case features for 7.7 (elastic#61161)
1dbe251
stephmilovic added a commit that referenced this pull request Mar 25, 2020
@stephmilovic
[SIEM] [Cases] Final case features for 7.7 (#61161) (#61208)
2df62cb
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierM XavierM XavierM approved these changes

@cnasikas cnasikas Awaiting requested review from cnasikas

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stephmilovic @elasticmachine @XavierM @kibanamachine @MindyRS