Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed kbn_tp_sample_app_plugin #61427

Merged
merged 4 commits into from
Mar 30, 2020
Merged

Removed kbn_tp_sample_app_plugin #61427

merged 4 commits into from
Mar 30, 2020

Conversation

VladLasitsa
Copy link
Contributor

@VladLasitsa VladLasitsa commented Mar 26, 2020 •
edited
Loading

Part of #51275

Summary

Removed kbn_tp_sample_app_plugin

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@VladLasitsa VladLasitsa self-assigned this Mar 26, 2020
@VladLasitsa VladLasitsa requested review from lizozom and alexwizp March 26, 2020 10:40
@lizozom
Copy link
Contributor

lizozom commented Mar 26, 2020

@VladLasitsa
Would you mind mentioning on the PR, for the record, why was this example removed? Is it because it's a setup demo for legacy plugins?

@VladLasitsa
Copy link
Contributor Author

VladLasitsa commented Mar 26, 2020 •
edited
Loading

@VladLasitsa
Would you mind mentioning on the PR, for the record, why was this example removed? Is it because it's a setup demo for legacy plugins?

@lizozom Yes, From my point of view, it is a useless plugin that just renders a one 'div' element and I think we can delete it. Do you see any reason to leave this plugin and migrate it to the new platform?

@alexwizp
Copy link
Contributor

alexwizp commented Mar 26, 2020 •
edited
Loading

@lizozom Hi Liza, let me clarify why we decided to remove this plugin. First of all in scope of #51275 we should migrate legacy plugins to new platform. The plugin kbn_tp_sample_app_plugin contains only one div inside, and I think it was originally created as an example for our developers to create new plugins.
As you know now we have a script for generation new plugins (node scripts/generate_plugin {plugin_name}). It's a good alternative than having sample plugin which we should keep updated

My suggestion: let's remove that plugin 😄

alexwizp
alexwizp approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@VladLasitsa VladLasitsa marked this pull request as ready for review March 30, 2020 10:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

streamich
streamich approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

@VladLasitsa VladLasitsa merged commit 5605b46 into elastic:master Mar 30, 2020
@VladLasitsa VladLasitsa mentioned this pull request Mar 30, 2020
Merged
VladLasitsa added a commit to VladLasitsa/kibana that referenced this pull request Mar 30, 2020
@VladLasitsa @elasticmachine
Removed kbn_tp_sample_app_plugin (elastic#61427)
ab4ebaf 
* Removed sample app test plugin

* Deleted old tests

* removed path

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
VladLasitsa added a commit that referenced this pull request Mar 31, 2020
@VladLasitsa @elasticmachine
Removed kbn_tp_sample_app_plugin (#61427) (#61807)
10681f6 
* Removed sample app test plugin

* Deleted old tests

* removed path

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexwizp alexwizp alexwizp approved these changes

@streamich streamich streamich approved these changes

@lizozom lizozom lizozom approved these changes

Assignees

@VladLasitsa VladLasitsa

Labels
Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@VladLasitsa @lizozom @alexwizp @elasticmachine @kibanamachine @streamich