Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM][CASE] Add the correct user information to each comment #61513

Merged
merged 1 commit into from
Mar 26, 2020
Merged

[SIEM][CASE] Add the correct user information to each comment #61513

merged 1 commit into from
Mar 26, 2020

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Mar 26, 2020 •
edited
Loading

Summary

Add the correct user information to each comment.

For maintainers

@cnasikas cnasikas added bug Fixes for quality problems that affect the customer experience Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 26, 2020
@cnasikas cnasikas requested a review from a team as a code owner March 26, 2020 18:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@cnasikas cnasikas linked an issue Mar 26, 2020 that may be closed by this pull request
[SIEM] [CASE] when pushing to service now we are not showing the right user #61350
Closed
@stephmilovic stephmilovic mentioned this pull request Mar 26, 2020
Closed
26 tasks
XavierM
XavierM approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mikecote
mikecote approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cnasikas cnasikas merged commit f462b10 into elastic:master Mar 26, 2020
@cnasikas cnasikas deleted the servicenow_fix_comment_user branch March 26, 2020 20:17
@cnasikas cnasikas mentioned this pull request Mar 26, 2020
Closed
cnasikas added a commit to cnasikas/kibana that referenced this pull request Mar 26, 2020
@cnasikas
[SIEM][CASE] Add the correct user information to each comment (elasti…
3dddeb0 
…c#61513)
cnasikas added a commit to cnasikas/kibana that referenced this pull request Mar 26, 2020
@cnasikas
[SIEM][CASE] Add the correct user information to each comment (elasti…
13f66df 
…c#61513)
@cnasikas cnasikas mentioned this pull request Mar 26, 2020
Closed
@XavierM
Copy link
Contributor

XavierM commented Mar 26, 2020

@mikecote @cnasikas

I made a mistake reviewing this PR it should be like that

date: c.updatedAt ?? c.createdAt,
user: c.updatedBy != null ? c.updatedBy.fullName ?? c.updatedBy.username : c.createdBy.fullName ?? c.createdBy.username

@cnasikas
Copy link
Member Author

Ok! I will fix it in another PR.

@cnasikas
Copy link
Member Author

Fixed on #61603

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 30, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 61513 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 61513 or prevent reminders by adding the backport:skip label.

@rylnd
Copy link
Contributor

rylnd commented Apr 1, 2020

The changes here were overwritten in #61603 (which was backported), so no backport is necessary.

@rylnd rylnd added the backport:skip This commit does not require backporting label Apr 1, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 1, 2020
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecote mikecote mikecote approved these changes

@XavierM XavierM XavierM approved these changes

@stephmilovic stephmilovic Awaiting requested review from stephmilovic

@YulNaumenko YulNaumenko Awaiting requested review from YulNaumenko

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SIEM] [CASE] when pushing to service now we are not showing the right user
7 participants
@cnasikas @elasticmachine @kibanamachine @XavierM @rylnd @mikecote @MindyRS