added a 1 minute timeout to require.js. #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume you didn't mean to add all those logstash dashboards? |
|
Correct — On Mon, Oct 28, 2013 at 7:54 AM, Rashid Khan notifications@github.com
|
|
Updated |
rashidkpc
pushed a commit
that referenced
this pull request
Oct 28, 2013
added a 1 minute timeout to require.js.
This was referenced Sep 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #604.
Turns out that require.js doesn't/can't cancel requests for scripts (since they are just
<script>tags) but simply stops waiting for them to load so that the app can somehow react when things are broken. Since Kibana doesn't have any sort of backup plan in place for retrying on load failure, extending the timeout to 1 minute shouldn't have any negative side-effects.