-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate test plugins ⇒ NP (kbn_tp_custom_visualizations) #61606
Migrate test plugins ⇒ NP (kbn_tp_custom_visualizations) #61606
Conversation
@elasticmachine merge upstream |
Pinging @elastic/kibana-app-arch (Team:AppArch) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
const counter = await getCounterValue(); | ||
expect(counter).to.be('10'); | ||
}); | ||
|
||
it('should allow changing params from within the vis', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leave this test skiped (don't remove it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* Migrated kbn_tp_custom_visualizations to the new platform * skip test instead of deleting Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
…1832) * Migrated kbn_tp_custom_visualizations to the new platform * skip test instead of deleting Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Part of #51275
Summary
migrated kbn_tp_custom_visualizations - creating custom visualizations in Kibana.
Checklist
Delete any items that are not applicable to this PR.
For maintainers