-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search service] Temporarily remove wait_for_completion async param #61677
Conversation
Pinging @elastic/kibana-app-arch (Team:AppArch) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on green
Failure is known flaky: #61690 |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
I am unable to reproduce the failure locally. If we hit that same error the tests should be skipped. |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
@elastic/kibana-app-arch merging without a codeowner review since this needs to unblock the ES snapshots. |
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Summary
Related: #61641
Since Elasticsearch renamed the
wait_for_completion
parameter, but we can't update the snapshots while there is a broken build, this PR provides an interim step toward #61641 which removes the parameter completely and instead uses a poll interval. Once this passes CI we can update the snapshots and once again start using the correct parameter name.Checklist
Delete any items that are not applicable to this PR.
For maintainers