Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search service] Temporarily remove wait_for_completion async param #61677

Merged
merged 3 commits into from
Mar 30, 2020

Conversation

lukasolson
Copy link
Member

Summary

Related: #61641

Since Elasticsearch renamed the wait_for_completion parameter, but we can't update the snapshots while there is a broken build, this PR provides an interim step toward #61641 which removes the parameter completely and instead uses a poll interval. Once this passes CI we can update the snapshots and once again start using the correct parameter name.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@lukasolson lukasolson added review Feature:Search Querying infrastructure in Kibana v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 27, 2020
@lukasolson lukasolson requested a review from a team as a code owner March 27, 2020 18:07
@lukasolson lukasolson self-assigned this Mar 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@tylersmalley
Copy link
Contributor

tylersmalley commented Mar 27, 2020

Failure is known flaky: #61690

@tylersmalley
Copy link
Contributor

@elasticmachine merge upstream

@tylersmalley
Copy link
Contributor

@elasticmachine merge upstream

@tylersmalley
Copy link
Contributor

I am unable to reproduce the failure locally. If we hit that same error the tests should be skipped.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley
Copy link
Contributor

@elastic/kibana-app-arch merging without a codeowner review since this needs to unblock the ES snapshots.

@tylersmalley tylersmalley merged commit 1855d10 into elastic:master Mar 30, 2020
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Mar 30, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Mar 30, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
tylersmalley pushed a commit that referenced this pull request Mar 30, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Lukas Olson <olson.lukas@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
tylersmalley pushed a commit that referenced this pull request Mar 30, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Lukas Olson <olson.lukas@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes review v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants