Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] [Case] Design fixing #61681

Merged
merged 11 commits into from
Mar 30, 2020
Merged

[SIEM] [Case] Design fixing #61681

merged 11 commits into from
Mar 30, 2020

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Mar 27, 2020 •
edited
Loading

Summary

Match up small details on the case design including some success toasters that got left out along with Tooltips.

Screen Shot 2020-03-27 at 12 53 28 PM

Screen Shot 2020-03-27 at 12 53 45 PM

Checklist

Delete any items that are not applicable to this PR.

@stephmilovic stephmilovic added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@stephmilovic stephmilovic marked this pull request as ready for review March 27, 2020 18:55
@stephmilovic stephmilovic requested a review from a team as a code owner March 27, 2020 18:55
@cnasikas
Copy link
Member

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

merge conflict between base and head

cnasikas
cnasikas approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stephmilovic stephmilovic merged commit 9831c12 into elastic:master Mar 30, 2020
@stephmilovic stephmilovic deleted the design-matching branch March 30, 2020 17:31
@stephmilovic stephmilovic mentioned this pull request Mar 30, 2020
Merged
stephmilovic added a commit to stephmilovic/kibana that referenced this pull request Mar 30, 2020
@stephmilovic
[SIEM] [Case] Design fixing (elastic#61681)
e75fd57
@stephmilovic stephmilovic mentioned this pull request Mar 30, 2020
Merged
stephmilovic added a commit to stephmilovic/kibana that referenced this pull request Mar 30, 2020
@stephmilovic
[SIEM] [Case] Design fixing (elastic#61681)
8487f00
stephmilovic added a commit that referenced this pull request Mar 30, 2020
@stephmilovic
[SIEM] [Case] Design fixing (#61681) (#61862)
bc93f27
stephmilovic added a commit that referenced this pull request Mar 30, 2020
@stephmilovic
[SIEM] [Case] Design fixing (#61681) (#61863)
5954bd4
@stephmilovic stephmilovic mentioned this pull request Mar 31, 2020
Closed
26 tasks
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierM XavierM XavierM left review comments

@cnasikas cnasikas cnasikas approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stephmilovic @elasticmachine @cnasikas @kibanamachine @XavierM @MindyRS