[SIEM] Restores the External alert count widget's subtitle #62094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-goldstein
added
Team:SIEM
v8.0.0
release_note:skip
|
Pinging @elastic/siem (Team:SIEM) |
angorayc
reviewed
Apr 1, 2020
angorayc
reviewed
Apr 1, 2020
x-pack/legacy/plugins/siem/public/pages/overview/alerts_by_category/index.test.tsx
Outdated
Show resolved
Hide resolved
angorayc
approved these changes
Apr 1, 2020
There was a problem hiding this comment.
Thank you @andrew-goldstein for the enhancement and unit tests, ran on my dev env. all looks good.
Fixes an issue where the _External alert count_ widget's subtitle, (e.g. `Showing: 47,642,905 external alerts`), didn't render after data is loaded ### Before  ### After 
andrew-goldstein
force-pushed
the
fix-alerts-by-category-subtitle
branch
from
ece3467 to
0047754
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This was referenced Apr 1, 2020
andrew-goldstein
added a commit
to andrew-goldstein/kibana
that referenced
this pull request
Apr 1, 2020
…#62094) ## [SIEM] Restores the _External alert count_ widget's subtitle Fixes an issue where the _External alert count_ widget's subtitle, (e.g. `Showing: 47,642,905 external alerts`), didn't render after data is loaded ### Before  ### After 
andrew-goldstein
added a commit
that referenced
this pull request
Apr 1, 2020
…#62205) ## [SIEM] Restores the _External alert count_ widget's subtitle Fixes an issue where the _External alert count_ widget's subtitle, (e.g. `Showing: 47,642,905 external alerts`), didn't render after data is loaded ### Before  ### After 
andrew-goldstein
added a commit
that referenced
this pull request
Apr 1, 2020
…#62206) ## [SIEM] Restores the _External alert count_ widget's subtitle Fixes an issue where the _External alert count_ widget's subtitle, (e.g. `Showing: 47,642,905 external alerts`), didn't render after data is loaded ### Before  ### After 
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 2, 2020
* master: [HomeApp] Set breadcrumbs when coming back from add data dir (elastic#62186) [Lens] fix error for minInterval>computedInterval for XYChart (elastic#61931) ci: remove AppArch label from ProBot path-labeler (elastic#62211) [Uptime] Optimize get latest monitor API (elastic#61820) [Maps] Separate layer wizards for Clusters and heatmap (elastic#60870) Remove polling delay (elastic#62099) accessibility tests for dashboard panel ( OSS) (elastic#62055) rename README.md to readme, avoiding issues with case change [SIEM] [Detection Engine] Fixes all rules sorting (elastic#62039) [SIEM] CASES Bugs BC2 (elastic#62170) Revert "Endpoint: Add ts-node dev dependency (elastic#61884)" (elastic#62197) Closes elastic#60173 by turning off client caching for the main service map API call (elastic#62111) [SIEM] Restores the _External alert count_ widget's subtitle (elastic#62094) [Maps] Update ems client dependency to 7.8.0 (elastic#62181) [Metrics Alerts] Fix action variables, default message, and EU… (elastic#62061) Update CODEOWNERS with ES-UI apps, including grok debugger. (elastic#62045) Update ILM node attributes blacklist. (elastic#62093)
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SIEM] Restores the External alert count widget's subtitle
Fixes an issue where the External alert count widget's subtitle, (e.g.
Showing: 47,642,905 external alerts), didn't render after data is loadedBefore
After