Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Functional API tests - fix mml request bodies #62116

Merged
merged 2 commits into from
Apr 1, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export default ({ getService }: FtrProviderContext) => {
detectors: [
{
function: 'avg',
field_name: 'geoip.city_name',
field_name: 'taxless_total_price',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, but seeing as we are editing this test, amend the title to with 1 metric and 1 influencer same as split field

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in c9d8a00

by_field_name: 'geoip.city_name',
},
],
Expand All @@ -84,7 +84,7 @@ export default ({ getService }: FtrProviderContext) => {
{
function: 'mean',
by_field_name: 'geoip.city_name',
field_name: 'geoip.city_name',
field_name: 'taxless_total_price',
},
],
influencers: ['geoip.city_name', 'customer_gender', 'customer_full_name.keyword'],
Expand All @@ -100,7 +100,7 @@ export default ({ getService }: FtrProviderContext) => {
},
},
{
testTitleSuffix: '4 influencers, split by customer_id and filtering by country code',
testTitleSuffix: '4 influencers, split by city and manufacturer + filtering by country code',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth adding to the test title that it uses 2 detectors

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in c9d8a00

user: USER.ML_POWERUSER,
requestBody: {
indexPattern: 'ecommerce',
Expand All @@ -109,13 +109,13 @@ export default ({ getService }: FtrProviderContext) => {
detectors: [
{
function: 'mean',
by_field_name: 'customer_id.city_name',
field_name: 'customer_id.city_name',
by_field_name: 'geoip.city_name',
field_name: 'taxless_total_price',
},
{
function: 'avg',
by_field_name: 'manufacturer.keyword',
field_name: 'manufacturer.keyword',
field_name: 'taxless_total_price',
},
],
influencers: [
Expand Down