Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

histogram: enable simple value-based histograms #622

Closed
wants to merge 1 commit into from
Closed

histogram: enable simple value-based histograms #622

wants to merge 1 commit into from

Conversation

jdve
Copy link

@jdve jdve commented Oct 28, 2013

This change enhances the histogram panel to support value-based
histograms in addition to time-series histograms. This means that
instead of bucketing the field across time intervals, simply bucket all
values together into a single set of buckets based on the value itself,
while still honoring the overall dashboard time-range criteria. This
type of graph provides a high-level perspective of a field's value.

@jdve
Copy link
Author

jdve commented Oct 28, 2013

Here's a screenshot of the type of graph this change can produce:

sync_times

@rashidkpc
Copy link
Contributor

I like this, though I wonder if it should be a separate panel. Long term, I think the existing histogram panel should be retired and replaced with a timeseries panel that is properly geared towards working with time series data

@jdve
Copy link
Author

jdve commented Oct 29, 2013

Yeah, I was wondering about that. As it is, I've managed to achieve quite a high degree of code reuse, but it smells of hackiness, especially the Interval.js changes. Are you thinking it would make more sense as a separate panel (from a logical, end-user point-of-view) ? Or do you have any suggestions about how to refactor this to be more clean? Are there any examples of panels inheriting from each other?

@rashidkpc
Copy link
Contributor

I think from both points of view this makes sense as a different, simplified panel. For example, things like the derivative function make no sense here, and even line charts don't really.

So far panels can't inherit from each other, but I'd be interested in design ideas around it. The idea makes a lot of sense.

@jdve
Copy link
Author

jdve commented Nov 1, 2013

Sounds good! I'll see what I can come up with. Thanks for the feedback!

This change adds a new valuehistogram panel to support value-based
histograms.  Unlike the previous histogram panel which plots the data
using fixed time-interval buckets, this type of histogram buckets the
data according to the values themselves.  This type of graph provides
a high-level perspective of a field's value across the entire time
interval.
@jdve
Copy link
Author

jdve commented Nov 6, 2013

@rashidkpc OK, here's an attempt to refactor this as a separate panel. It's a straight copy of the existing histogram panel with the necessary changes for this form of chart and the unrelated features culled out. How does this look?

From a naming perspective, I could see the existing histogram panel being renamed to "datehistogram" (to be consistent with the elasticsearch facet), but that would be very backward incompatible.

@johanndt
Copy link

Hi jdve

I like this idea, but having trouble fetching this in git since it doesn't list a branch with this commit in your repo. Did you delete the branch or is it private somehow?

Thanks,
Johann (aka Skillflip previously - changed account recently)

@jdve
Copy link
Author

jdve commented May 21, 2014

Yes, I think I recreated this repo at one point. I've just pushed up the branch again, so you can grab it from there if you like. Also, this time it's rebased against the tip of the upstream:

https://github.com/jdve/kibana/tree/histogram-values

@johanndt
Copy link

Thanks heaps for this. I'll have a play today.

@KhaoticMind
Copy link

@rashidkpc any chance of merging it upstream?

@smithamax
Copy link

👍 I was so disappointed when I found out you couldn't do this with the current histogram.

@rashidkpc
Copy link
Contributor

We have this on the roadmap for a future version. Unfortunately I can't offer an ETA other than soon :-)

@dchichkov
Copy link

Tried it with kibana from Jul/8/2014 and Firefox/Chrome. I couldn't create the plot (editor doesn't update correctly; save button is grayed out). No suspicious messages in the javascript console.

I guess the 'API' had changed somehow between the end of 2013 and now...

@xingwx
Copy link

xingwx commented Jul 25, 2014

@dchichkov
change underscore to lowdash, then it works fine.

@hhcalder92
Copy link

I was having problems generating the graph, Firebug returned a 404 error for underscore.js. By merely downloading underscore.js and placinging it in /src, the error is fixed. Thanks @jdve, have been trying to create a valueHistogram.

@momok2 momok2 mentioned this pull request Sep 26, 2014
@momok2
Copy link

momok2 commented Oct 6, 2014

@hhcalder92
where can i find the underscore.js file ?

@w33ble w33ble closed this Oct 6, 2014
@spalger
Copy link
Contributor

spalger commented Oct 6, 2014

Woops! Sorry about that! We recently replaced the master branch with Kibana 4. This action force closed all of the old pull requests against master. We will be reviewing these on a case-by-case basis and creating new tickets as necessary.

The good news is that many long requested features can be found in Kibana 4, and we're being entirely open about our roadmap. Check out the roadmap tickets (which we're still filling in) here.

If you're looking for the old Kibana 3 code you can find it here.

@rashidkpc
Copy link
Contributor

We've implemented this in Kibana 4

screen shot 2014-10-08 at 1 37 20 pm

@hhcalder92
Copy link

AWESOME!!! Thank you!! @rashidkpc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.