[APM] Agent remote configuration: changes in Java property descriptions #62282

eyalkoren · 2020-04-02T10:02:56Z

Some changes required for the Java property descriptions

elasticmachine · 2020-04-02T10:02:58Z

Pinging @elastic/apm-ui (Team:apm)

bmorelli25 · 2020-04-02T17:54:51Z

bmorelli25 · 2020-04-02T17:58:50Z

x-pack/plugins/apm/common/agent_configuration/setting_definitions/java_settings.ts

@@ -175,7 +176,7 @@ export const javaSettings: RawSettingDefinition[] = [
      'xpack.apm.agentConfig.profilingInferredSpansEnabled.description',
      {
        defaultMessage:
-          'Set to `true` to make the agent create spans for method executions based on async-profiler, a sampling aka statistical profiler. Due to the nature of how sampling profilers work, the duration of the inferred spans are not exact, but only estimations. The `profiling_inferred_spans_sampling_interval` lets you fine tune the trade-off between accuracy and overhead. The inferred spans are created after a profiling session has ended. This means there is a delay between the regular and the inferred spans being visible in the UI. This feature is not available on Windows'
+          'Set to `true` to make the agent create spans for method executions based on async-profiler, a sampling (aka statistical profiler). Due to the nature of how sampling profilers work, the duration of the inferred spans are not exact, but only estimations. The `profiling_inferred_spans_sampling_interval` lets you fine tune the trade-off between accuracy and overhead. The inferred spans are created after a profiling session has ended. This means there is a delay between the regular and the inferred spans being visible in the UI.\n\nNOTE: This feature is not available on Windows.'


I get what you're going for, but I don't the the parenthesis work in this case. Also, do the newlines actually render?

Here's a parenthesis suggestion:

Suggested change

'Set to `true` to make the agent create spans for method executions based on async-profiler, a sampling (aka statistical profiler). Due to the nature of how sampling profilers work, the duration of the inferred spans are not exact, but only estimations. The `profiling_inferred_spans_sampling_interval` lets you fine tune the trade-off between accuracy and overhead. The inferred spans are created after a profiling session has ended. This means there is a delay between the regular and the inferred spans being visible in the UI.\n\nNOTE: This feature is not available on Windows.'

'Set to `true` to make the agent create spans for method executions based on async-profiler, a sampling (or statistical) profiler. Due to the nature of how sampling profilers work, the duration of the inferred spans are not exact, but only estimations. The `profiling_inferred_spans_sampling_interval` lets you fine tune the trade-off between accuracy and overhead. The inferred spans are created after a profiling session has ended. This means there is a delay between the regular and the inferred spans being visible in the UI.\n\nNOTE: This feature is not available on Windows.'

Let's restore the former - a sampling aka statistical profiler.. I thought it would be better with parentheses, but seems you think it won't, so I will restore.
The main change I wanted here is the separation of the NOTE. I don't know about these newlines, I just saw what you did in other descriptions and did the same 🙂 . Since you found they do not render, I will remove...
So currently we have no formatting for these sections whatsoever?

Ok, sounds good! Correct, there's unfortunately no formatting

bmorelli25

One suggestion. Also, I noticed you added some of the newlines back in. Do those actually render? It didn't seem like they did when I worked on my previous PR.

smith · 2020-04-07T18:55:54Z

retest

smith · 2020-04-07T22:09:12Z

retest

smith · 2020-04-08T16:04:56Z

retest

smith · 2020-04-08T18:22:08Z

retest

smith · 2020-04-08T20:13:25Z

@elasticmachine merge upstream

kibanamachine · 2020-04-08T21:53:09Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 4d4fbd8

History

💔 Build #39698 failed 762ed28
💔 Build #39636 failed 762ed28
💔 Build #39459 failed 762ed28
💔 Build #39405 failed 762ed28
💔 Build #39337 failed 762ed28

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…ns (elastic#62282) * [APM] Agent remote configuration: changes in Java property descriptions * Removing newlines * Update snapshot Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co> Co-authored-by: Nathan L Smith <smith@nlsmith.com>

…ns (#62282) (#63066) * [APM] Agent remote configuration: changes in Java property descriptions * Removing newlines * Update snapshot Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co> Co-authored-by: Nathan L Smith <smith@nlsmith.com> Co-authored-by: eyalkoren <41850454+eyalkoren@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>

…chore/put-all-xjson-together * 'master' of github.com:elastic/kibana: (35 commits) [SIEM] [Detection Engine] Fixes bug when notification doesn't… (elastic#63013) [SIEM][Detection Engine] Fix rule notification critical bugs Add Error Exception Type Column (elastic#59596) [APM] Agent remote configuration: changes in Java property descriptions (elastic#62282) [Alerting] Displays warning when a permanent encryption key is missing and hides alerting UI appropriately (elastic#62772) FTR: add chromium-based Edge browser support (elastic#61684) [Ingest] Data source configuration validation UI (elastic#61180) restore empty_kibana after saved objects test (elastic#62951) Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin (elastic#62594) Add basic StatusService (elastic#60335) [kbn/optimizer] link to kibanaReact/kibanaUtils plugins (elastic#62720) [APM] Service map - fixes layout issues for maps with no rum services (elastic#62887) Exclude disabled datasources and streams from agent config (elastic#62869) [Alerting] Fix validation support for nested IErrorObjects (elastic#62833) [Metrics UI] Invalidate non-count alerts which have no metrics (elastic#62837) Add --filter option to API docs script (elastic#62888) [Maps] fix attribution overflow with exit full screen button (elastic#62699) [Uptime]Alerting UI text in case filter is selected (elastic#62570) [Maps] Show create filter button for top-term tooltip property (elastic#62461) skip flaky suite (elastic#59030) ... # Conflicts: # src/plugins/es_ui_shared/public/index.ts

* master: (40 commits) [ML] Functional transform tests - stabilize source selection (elastic#63087) add embed flag to saved object url as well (elastic#62926) [SIEM] [Detection Engine] Fixes bug when notification doesn't… (elastic#63013) [SIEM][Detection Engine] Fix rule notification critical bugs Add Error Exception Type Column (elastic#59596) [APM] Agent remote configuration: changes in Java property descriptions (elastic#62282) [Alerting] Displays warning when a permanent encryption key is missing and hides alerting UI appropriately (elastic#62772) FTR: add chromium-based Edge browser support (elastic#61684) [Ingest] Data source configuration validation UI (elastic#61180) restore empty_kibana after saved objects test (elastic#62951) Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin (elastic#62594) Add basic StatusService (elastic#60335) [kbn/optimizer] link to kibanaReact/kibanaUtils plugins (elastic#62720) [APM] Service map - fixes layout issues for maps with no rum services (elastic#62887) Exclude disabled datasources and streams from agent config (elastic#62869) [Alerting] Fix validation support for nested IErrorObjects (elastic#62833) [Metrics UI] Invalidate non-count alerts which have no metrics (elastic#62837) Add --filter option to API docs script (elastic#62888) [Maps] fix attribution overflow with exit full screen button (elastic#62699) [Uptime]Alerting UI text in case filter is selected (elastic#62570) ...

…ns (#62282) (#63067) * [APM] Agent remote configuration: changes in Java property descriptions * Removing newlines * Update snapshot Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co> Co-authored-by: Nathan L Smith <smith@nlsmith.com> Co-authored-by: eyalkoren <41850454+eyalkoren@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>

[APM] Agent remote configuration: changes in Java property descriptions

2ee8ac6

eyalkoren added bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support labels Apr 2, 2020

eyalkoren requested review from smith and bmorelli25 April 2, 2020 10:02

eyalkoren requested a review from a team as a code owner April 2, 2020 10:02

bmorelli25 added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Apr 2, 2020

Merge branch 'master' into eyalkoren-suggested-changes-2

ac22d55

bmorelli25 reviewed Apr 2, 2020

View reviewed changes

Removing newlines

e8f2012

bmorelli25 approved these changes Apr 7, 2020

View reviewed changes

bmorelli25 and others added 2 commits April 6, 2020 17:36

Merge branch 'master' into eyalkoren-suggested-changes-2

72f1c42

Update snapshot

762ed28

smith mentioned this pull request Apr 7, 2020

[APM] Agent Configuration test scenarios #61694

Closed

Merge branch 'master' into eyalkoren-suggested-changes-2

4d4fbd8

smith merged commit da51cc0 into master Apr 8, 2020

smith mentioned this pull request Apr 8, 2020

[7.x] [APM] Agent remote configuration: changes in Java property descriptions (#62282) #63066

Merged

smith mentioned this pull request Apr 8, 2020

[7.7] [APM] Agent remote configuration: changes in Java property descriptions (#62282) #63067

Merged

smith added apm-test-plan-7.7.0 apm:test-plan-done Pull request that was successfully tested during the test plan labels Apr 21, 2020

spalger deleted the eyalkoren-suggested-changes-2 branch May 8, 2022 22:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[APM] Agent remote configuration: changes in Java property descriptions #62282

[APM] Agent remote configuration: changes in Java property descriptions #62282

eyalkoren commented Apr 2, 2020

elasticmachine commented Apr 2, 2020

bmorelli25 commented Apr 2, 2020

bmorelli25 Apr 2, 2020

eyalkoren Apr 5, 2020

bmorelli25 Apr 7, 2020

bmorelli25 left a comment

smith commented Apr 7, 2020

smith commented Apr 7, 2020

smith commented Apr 8, 2020

smith commented Apr 8, 2020

smith commented Apr 8, 2020

kibanamachine commented Apr 8, 2020

[APM] Agent remote configuration: changes in Java property descriptions #62282

[APM] Agent remote configuration: changes in Java property descriptions #62282

Conversation

eyalkoren commented Apr 2, 2020

elasticmachine commented Apr 2, 2020

bmorelli25 commented Apr 2, 2020

bmorelli25 Apr 2, 2020

Choose a reason for hiding this comment

eyalkoren Apr 5, 2020

Choose a reason for hiding this comment

bmorelli25 Apr 7, 2020

Choose a reason for hiding this comment

bmorelli25 left a comment

Choose a reason for hiding this comment

smith commented Apr 7, 2020

smith commented Apr 7, 2020

smith commented Apr 8, 2020

smith commented Apr 8, 2020

smith commented Apr 8, 2020

kibanamachine commented Apr 8, 2020

💚 Build Succeeded

History