Server-side create/update ingest pipelines

[alisonelizabeth]

This PR adds the create and update endpoints to the ingest pipelines app.

PUT /api/ingest_pipelines

Create a new pipeline

Example body

{
    "name": "my_pipeline",
    "description": "pipeline description",
    "version": 1,
    "processors" : [
      {
        "set" : {
          "field": "foo",
          "value": "bar"
        }
      }
    ],
    onFailure: [
      {
         set: {
           field: 'error.message',
           value: '{{ failure_message }}'
       	 }
      }
    ]
}

PUT /api/ingest_pipelines/<existing_pipeline>

Update an existing pipeline

Example body

{
    "description": "updated pipeline description",
    "version": 2,
    "processors" : [
      {
        "set" : {
          "field": "foo",
          "value": "bar"
        }
      }
    ]
}

[elasticmachine]

Pinging @elastic/es-ui (Team:Elasticsearch UI)

[alisonelizabeth]

@elasticmachine merge upstream

[alisonelizabeth]

@elasticmachine merge upstream

[jloleysens]

Left a few comments that you can choose to address, otherwise I am happy for this to be merged once CI passes!

I just checked that Kibana starts locally. #test-confidence

[jloleysens]

Just curious, what issues was having e.g., { version: undefined ... } causing?

[alisonelizabeth]

I noticed we had followed this pattern elsewhere, but you bring up a good point. It's not causing any issues atm, so I removed this logic for now.

[jloleysens]

Could we check for 404 here as a success indicator and return internal error otherwise?

[alisonelizabeth]

I don't know if we would want to block on this. WDYT?

[alisonelizabeth]

I'm going to leave this as is for now, so I can merge this PR and start working on the UI. I'm open to revisiting it in a follow-up PR though.

[jloleysens]

We should consider modifying license service gaurdApiRoute to preserve type information:

  guardApiRoute<P, Q, B>(handler: RequestHandler<P, Q, B>) {
    const license = this;

    return function licenseCheck(
      ctx: RequestHandlerContext,
      request: KibanaRequest<P, Q, B>,

Then we can remove as declarations (although I can see we may want to keep as Pipeline on the body).

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: d6f862c

History

• 💚 Build #39444 succeeded 664c6ad
• 💔 Build #39422 failed 5d65c88
• 💚 Build #39264 succeeded edaf515
• 💔 Build #39183 failed c93c07b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[sebelga]

To follow REST principles it would be better to use POST to create a resource. Tiny change but it goes a long way 😄

[alisonelizabeth]

Good point. I can change this in a follow-up PR. I think I may have used put here originally to align with the underlying ES API.

[alisonelizabeth]

Change made via 6bba3da