Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest] Update Create datasource UI to fit in one page #62858

Merged

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Apr 7, 2020

Description

Resolves #60696

Convert the existing create datasource pages into one page.

Change:

  • Convert the multiple pages to one
  • add a bottom bar
  • add a modal to confirm creation if some agents already enrolled to that config.

Screenshots

Updated header
Screen Shot 2020-04-09 at 5 11 26 PM

Screen Shot 2020-04-08 at 3 35 57 PM

Screen Shot 2020-04-08 at 3 36 08 PM

Screen Shot 2020-04-08 at 3 36 17 PM

@nchaulet nchaulet added the Team:Fleet Team label for Observability Data Collection Fleet team label Apr 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@nchaulet nchaulet changed the title [Ingest] Create datasource in one page [Ingest] Update Create datasource UI to fit in one page Apr 7, 2020
@nchaulet nchaulet force-pushed the feature-ingest-new-create-datasource-steps branch from 081d59f to d22ea9f Compare April 8, 2020 15:41
@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0 labels Apr 8, 2020
@nchaulet nchaulet self-assigned this Apr 8, 2020
@nchaulet nchaulet marked this pull request as ready for review April 8, 2020 15:52
@nchaulet nchaulet requested a review from a team April 8, 2020 15:52
@jen-huang
Copy link
Contributor

Going to do a full review later but just an FYI that @hbharding updated the designs a bit so that the bottom bar does not cover the side nav (for both expanded and collapsed side nav):

image

Here's an example PR that accounts for the side nav with a bottom bar (thanks @cjcenizal!): #60833

@hbharding
Copy link
Contributor

Looks great thanks @nchaulet! You probably noticed the "disabled" steps 2+3 don't exist in EUI the way i showed them in my designs. I spoke with the EUI team and I'll be working on a small PR to add this, but we'll have to wait until the next release

@nchaulet
Copy link
Member Author

nchaulet commented Apr 9, 2020

@hbharding Yes currently we can only disable the step badge

@nchaulet nchaulet requested a review from jen-huang April 9, 2020 17:53
Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual review:

  • The left and right margins around the content is bit weird. I think we probably need to reduce the max width of the content (in both the grey header and page content). @hbharding do you have a recommendation for the max width?

image

  • The header content that shows "Integration" and/or "Configuration" can be removed as per designs; the page title also needs to be changed. Design:

image

  • After de-selecting the integration (or configuration, if coming from EPM), the save button should be disabled again. Right now it stays enabled:

image

@jen-huang
Copy link
Contributor

One future enhancement that might be nice would be to scroll down to Step 2 after the user makes a selection in Step 1. Step 1 takes most of my viewport when I'm on laptop. Not required for this PR, but @hbharding how do you feel about automatic scroll?

@nchaulet
Copy link
Member Author

nchaulet commented Apr 9, 2020

The header content that shows "Integration" and/or "Configuration" can be removed as per designs; the page title also needs to be changed.

@jen-huang @hbharding what do you think of keeping it? I think it help keeping the context from where you come from

@hbharding
Copy link
Contributor

Lets keep it. I updated the design:
image

@hbharding
Copy link
Contributor

Also noticed 1 small thing about the layout. My designs use a tighter wrapper for the header and the body area. The design is 770px... or 8 / 12 columns... or 66% the width of the page wrapper, which is 1168px (1200px is you include left/right margin) :) I'll leave it up to you to decide how we do this.

@nchaulet
Copy link
Member Author

nchaulet commented Apr 9, 2020

@elasticmachine merge upstream

@nchaulet nchaulet requested a review from jen-huang April 9, 2020 22:49
Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few copy suggestions but otherwise LGTM! Thanks for making the changes.

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet nchaulet removed the request for review from a team April 13, 2020 12:49
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ingest] Agent configuration - create data source UI
5 participants