-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest] Update Create datasource UI to fit in one page #62858
[Ingest] Update Create datasource UI to fit in one page #62858
Conversation
Pinging @elastic/ingest-management (Team:Ingest Management) |
081d59f
to
d22ea9f
Compare
...ons/ingest_manager/sections/agent_config/create_datasource_page/components/confirm_modal.tsx
Outdated
Show resolved
Hide resolved
...er/public/applications/ingest_manager/sections/agent_config/create_datasource_page/index.tsx
Outdated
Show resolved
Hide resolved
Going to do a full review later but just an FYI that @hbharding updated the designs a bit so that the bottom bar does not cover the side nav (for both expanded and collapsed side nav): Here's an example PR that accounts for the side nav with a bottom bar (thanks @cjcenizal!): #60833 |
Looks great thanks @nchaulet! You probably noticed the "disabled" steps 2+3 don't exist in EUI the way i showed them in my designs. I spoke with the EUI team and I'll be working on a small PR to add this, but we'll have to wait until the next release |
@hbharding Yes currently we can only disable the step badge |
…t-new-create-datasource-steps
…t-new-create-datasource-steps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visual review:
- The left and right margins around the content is bit weird. I think we probably need to reduce the max width of the content (in both the grey header and page content). @hbharding do you have a recommendation for the max width?
- The header content that shows "Integration" and/or "Configuration" can be removed as per designs; the page title also needs to be changed. Design:
- After de-selecting the integration (or configuration, if coming from EPM), the save button should be disabled again. Right now it stays enabled:
...ons/ingest_manager/sections/agent_config/create_datasource_page/components/confirm_modal.tsx
Outdated
Show resolved
Hide resolved
...ons/ingest_manager/sections/agent_config/create_datasource_page/components/confirm_modal.tsx
Outdated
Show resolved
Hide resolved
...plications/ingest_manager/sections/agent_config/create_datasource_page/components/layout.tsx
Outdated
Show resolved
Hide resolved
...plications/ingest_manager/sections/agent_config/create_datasource_page/components/layout.tsx
Outdated
Show resolved
Hide resolved
One future enhancement that might be nice would be to scroll down to Step 2 after the user makes a selection in Step 1. Step 1 takes most of my viewport when I'm on laptop. Not required for this PR, but @hbharding how do you feel about automatic scroll? |
@jen-huang @hbharding what do you think of keeping it? I think it help keeping the context from where you come from |
Also noticed 1 small thing about the layout. My designs use a tighter wrapper for the header and the body area. The design is 770px... or 8 / 12 columns... or 66% the width of the page wrapper, which is 1168px (1200px is you include left/right margin) :) I'll leave it up to you to decide how we do this. |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few copy suggestions but otherwise LGTM! Thanks for making the changes.
...er/public/applications/ingest_manager/sections/agent_config/create_datasource_page/index.tsx
Outdated
Show resolved
Hide resolved
...plications/ingest_manager/sections/agent_config/create_datasource_page/components/layout.tsx
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
…om:nchaulet/kibana into feature-ingest-new-create-datasource-steps
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Description
Resolves #60696
Convert the existing create datasource pages into one page.
Change:
Screenshots
Updated header