Ingest overview page #63214
Merged
Ingest overview page #63214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbharding
added
in progress
Team:Fleet
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
|
I think this is ready to merge. I'll need help in a separate issue/PR to finish the rest:
|
nchaulet
added
release_note:skip
nchaulet
reviewed
Apr 17, 2020
| <Message> | ||
| <p> | ||
| <small> | ||
| <strong>Alpha release</strong> – Ingest Manager is under active development and is not |
There was a problem hiding this comment.
Maybe use a FormattedMessage here so we can have translations
There was a problem hiding this comment.
good catch, thanks
nchaulet
reviewed
Apr 17, 2020
x-pack/plugins/ingest_manager/public/applications/ingest_manager/components/alpha_messaging.tsx
Outdated
Show resolved
Hide resolved
nchaulet
reviewed
Apr 17, 2020
x-pack/plugins/ingest_manager/public/applications/ingest_manager/components/alpha_messaging.tsx
Outdated
Show resolved
Hide resolved
nchaulet
approved these changes
Apr 17, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
hbharding
pushed a commit
to hbharding/kibana
that referenced
this pull request
Apr 20, 2020
* use fixed table layout * added markup structure / css for overview page * add flyout and links to other pages * add "alpha" messaging at bottom of all pages * attrs instead of defaultProps on styled components * use FormattedMessage on alpha messaging component * remove leftover code * remove unused import
22 tasks
jen-huang
reviewed
Apr 20, 2020
Comment on lines
+23
to
+24
| display: flex; | ||
| flex-direction: column; |
There was a problem hiding this comment.
I reverted the flex properties here, as well as in with_header and without_header layouts in #63992.
The flex properties were breaking other pages, causing them not to expand to full width. It didn't seem like the removal affected the overview page contents or the alpha messaging so hopefully it's good to go. For future reference if a page content needs flex, the individual pages should wrap its contents in EuiFlexGroup or similar. The base layouts will rarely need adjusting :)
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 21, 2020
* master: (30 commits) Migrate vis_type_table to kibana/new platform (elastic#63105) Enable include/exclude in Terms agg for numeric fields (elastic#59425) follow conventions for saved object definitions (elastic#63571) [Docs]Adds saved object key setting to load balancing kib instances (elastic#63935) kbn/config-schema: Consider maybe properties as optional keys in ObjectType (elastic#63838) Fix page layouts, clean up unused code (elastic#63992) [SIEM] Adds recursive exact key checks for validation and formatter [Maps] Migrate remaining maps client files to NP (except routi… (elastic#63859) [Maps] Do not fetch geo_shape from docvalues (elastic#63997) Vega doc changes (elastic#63889) [Metrics UI] Reorganize file layout for Metrics UI (elastic#60049) Add sub-menus to Resolver node (for 75% zoom) (elastic#63476) [FTR] Add test suite metrics tracking/output (elastic#62515) [ML] Fixing single metric viewer page padding (elastic#63839) [Discover] Allow user to generate a report after saving a modified saved search (elastic#63623) [Reporting] Config flag to escape formula CSV values (elastic#63645) [Metrics UI] Remove remaining field filtering (elastic#63398) [Maps] fix date labels (elastic#63909) [TSVB] Use default Kibana palette for split series (elastic#62241) Ingest overview page (elastic#63214) ...
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
removed
the
backport missing
jen-huang
pushed a commit
that referenced
this pull request
Apr 22, 2020
* use fixed table layout * added markup structure / css for overview page * add flyout and links to other pages * add "alpha" messaging at bottom of all pages * attrs instead of defaultProps on styled components * use FormattedMessage on alpha messaging component * remove leftover code * remove unused import Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #62113
Initial PR for Ingest Manager overview page. I added messaging about being in a "alpha release" at the bottom of all pages.