[NP] Move visTypeXy plugin #63449
Merged
[NP] Move visTypeXy plugin #63449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 tasks
sulemanof
added
Feature:NP Migration
release_note:skip
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
flash1293
requested changes
Apr 14, 2020
| expressions: npStart.plugins.expressions, | ||
| visualizations: npStart.plugins.visualizations, | ||
| export const config = { | ||
| schema: schema.object({ enabled: schema.boolean({ defaultValue: true }) }), |
There was a problem hiding this comment.
default value should false.
There was a problem hiding this comment.
Ahh, sure, thanks!
Updated!
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
flash1293
approved these changes
Apr 15, 2020
sulemanof
added a commit
to sulemanof/kibana
that referenced
this pull request
Apr 15, 2020
* Move vis_type_xy into NP * Substitute usage in vis_type_vislib * Disable plugin by default # Conflicts: # .github/CODEOWNERS
sulemanof
added a commit
that referenced
this pull request
Apr 15, 2020
wayneseymour
pushed a commit
that referenced
this pull request
Apr 15, 2020
* Move vis_type_xy into NP * Substitute usage in vis_type_vislib * Disable plugin by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
For maintainers