[Discuss] Remove expressions plugin's dependency on inspector plugin #63841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
Feature:ExpressionLanguage
streamich
added
Feature:Visualizations
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
lizozom
reviewed
Apr 19, 2020
|
@elasticmachine merge upstream |
ppisljar
reviewed
Apr 20, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
kibanamachine
removed
the
backport missing
streamich
added a commit
that referenced
this pull request
Apr 22, 2020
…63841) (#63958) * refactor: 💡 use inspector service in visualizations to open it * refactor: 💡 remove expressions plugin dependency on inspector * test: 💍 fix Jest mock * fix: 🐛 remove Inspectore from Expressions plugin dependency inf * docs: ✏️ add JSDocs for createStartServicesGetter() method * test: 💍 fix TypeScript errors in expressions mocks Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes
expressionsplugin's dependency oninspectorplugin.Curious to learn if there is a reason why
expressionsplugin was made dependent oninspectorplugin in order to open Inspector's flyout? Otherwise, it seems thatexpressionsplugin should not depend oninspectorplugin.