-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics Alerts] Add outside range comparator #63993
Conversation
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
@elastic/kibana-alerting-services I added this as a custom comparator and extended the |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
I think that would make sense, what do you think @YulNaumenko or @pmuellr ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@Zacqary works for me 🙏 thank you! |
Summary
Closes #61825
Adds the
OUTSIDE_RANGE
comparator. I figured the least awkward way to express this in the Expression Editor was with the language "Is not between":I thought about "Is outside the range of" but that seemed needlessly long. Open to other suggestions.
This PR also consolidates some type checking.
Checklist
Delete any items that are not applicable to this PR.