[Uptime] Certificates page #64059

shahzad31 · 2020-04-21T11:27:18Z

Summary

Fixes: elastic/uptime#161
Added Cert Page

elasticmachine · 2020-04-21T11:27:23Z

Pinging @elastic/uptime (Team:uptime)

katrin-freihofner

Looks good to me!

x-pack/legacy/plugins/uptime/public/components/certificates/cert_status.tsx

x-pack/legacy/plugins/uptime/public/components/certificates/certificates_list.tsx

x-pack/legacy/plugins/uptime/public/components/certificates/translations.ts

x-pack/legacy/plugins/uptime/public/components/overview/monitor_list/cert_status_column.tsx

x-pack/legacy/plugins/uptime/public/components/overview/monitor_list/monitor_list.tsx

x-pack/legacy/plugins/uptime/public/pages/certificates.tsx

x-pack/legacy/plugins/uptime/public/components/overview/monitor_list/monitor_list.tsx

andrewvc

Needs some minor changes. Overall, very clean code!

x-pack/plugins/uptime/public/components/certificates/__tests__/cert_status.test.tsx

x-pack/plugins/uptime/public/components/certificates/certificates_list.tsx

...time/public/components/monitor/monitor_status_details/monitor_status_bar/ssl_certificate.tsx

...ns/uptime/public/components/monitor/monitor_status_details/monitor_status_bar/status_bar.tsx

x-pack/test/functional/es_archives/uptime/full_heartbeat/mappings.json

justinkambic

This is a great feature addition, and the code is super clean and well thought-out.

I had a few comments but great that we're this close on an initial review for such a large change!

x-pack/plugins/uptime/public/components/certificates/cert_status.tsx

x-pack/plugins/uptime/public/components/certificates/certificates_list.tsx

x-pack/plugins/uptime/public/components/certificates/fingerprint_col.tsx

x-pack/test/functional/services/uptime/certificates.ts

x-pack/plugins/uptime/public/state/api/certificates.ts

x-pack/plugins/uptime/public/state/reducers/ml_anomaly.ts

x-pack/plugins/uptime/public/state/reducers/monitor_list.ts

andrewvc

LGTM Pending @justinkambic 's changes

kibanamachine · 2020-05-01T13:39:34Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b2adcda

History

💚 Build #44631 succeeded b8ea75c
💔 Build #44486 failed 9abd565
💔 Build #44434 failed bba5e5e
💔 Build #44404 failed 18e7f1c
💔 Build #44094 failed 9aab27b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* upstream/master: (315 commits) [APM] Fix failing `ApmIndices` test (elastic#64965) [APM] Fix paths for ts optimization script (elastic#65012) Use HDR for percentiles (elastic#64758) [EPM] fix updates available filter (elastic#64957) [Uptime] Certificates page (elastic#64059) load lens app lazily (elastic#64769) [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954) Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742) [data.search.aggs] Remove legacy aggs APIs. (elastic#64719) Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927) [Discover] Show doc viewer action buttons on focus (elastic#64912) [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932) [Metrics UI] Add inventory metric threshold alerts (elastic#64292) [Canvas] Adds edit menu (elastic#64738) [Canvas] Adds refresh and autoplay options to view menu (elastic#64375) [Lens] Trigger a filter action on click in datatable visualization (elastic#63840) [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450) [APM] Client new platform migration (elastic#64046) [Monitoring] NP Migration complete client cutover (elastic#62908) Ingest Node Pipelines UI (elastic#62321) ...

…or-part-mvp-2 * 'master' of github.com:elastic/kibana: (51 commits) [APM] Fix failing `ApmIndices` test (elastic#64965) [APM] Fix paths for ts optimization script (elastic#65012) Use HDR for percentiles (elastic#64758) [EPM] fix updates available filter (elastic#64957) [Uptime] Certificates page (elastic#64059) load lens app lazily (elastic#64769) [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954) Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742) [data.search.aggs] Remove legacy aggs APIs. (elastic#64719) Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927) [Discover] Show doc viewer action buttons on focus (elastic#64912) [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932) [Metrics UI] Add inventory metric threshold alerts (elastic#64292) [Canvas] Adds edit menu (elastic#64738) [Canvas] Adds refresh and autoplay options to view menu (elastic#64375) [Lens] Trigger a filter action on click in datatable visualization (elastic#63840) [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450) [APM] Client new platform migration (elastic#64046) [Monitoring] NP Migration complete client cutover (elastic#62908) Ingest Node Pipelines UI (elastic#62321) ... # Conflicts: # x-pack/plugins/ingest_pipelines/common/types.ts # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form_fields.tsx # x-pack/plugins/ingest_pipelines/public/shared_imports.ts

* master: (44 commits) onEvent prop for expression component (elastic#64995) [APM] Fix failing `ApmIndices` test (elastic#64965) [APM] Fix paths for ts optimization script (elastic#65012) Use HDR for percentiles (elastic#64758) [EPM] fix updates available filter (elastic#64957) [Uptime] Certificates page (elastic#64059) load lens app lazily (elastic#64769) [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954) Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742) [data.search.aggs] Remove legacy aggs APIs. (elastic#64719) Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927) [Discover] Show doc viewer action buttons on focus (elastic#64912) [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932) [Metrics UI] Add inventory metric threshold alerts (elastic#64292) [Canvas] Adds edit menu (elastic#64738) [Canvas] Adds refresh and autoplay options to view menu (elastic#64375) [Lens] Trigger a filter action on click in datatable visualization (elastic#63840) [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450) [APM] Client new platform migration (elastic#64046) [Monitoring] NP Migration complete client cutover (elastic#62908) ...

shahzad31 added 15 commits April 7, 2020 14:17

WIP

3cdf756

Merge branch 'master' into certificate-page

abdfd3d

Updated Code

7103860

WIP

c8c785b

Merge branch 'master' into certificate-page

aadfe22

update

f2983b3

Merge branch 'master' into certificate-page

9a85cf2

update settings

9d29367

added cert form

853baa7

update settings

6b438ae

Merge branch 'master' into certificate-page

9c9ada4

Merge branch 'master' into certificate-page

ab518f1

cert column

ec0ed82

Merge branch 'master' into certificate-page

6078c1c

add pagination

95498df

botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Apr 21, 2020

shahzad31 added 5 commits April 21, 2020 22:17

added in monitor list tls info

82c5f63

added in monitor list tls info

4660ac7

fixed types

6c300ea

fixed types

cdecb48

updated

8c329b8

katrin-freihofner reviewed Apr 22, 2020

View reviewed changes

shahzad31 added 7 commits April 23, 2020 10:13

update

3645e02

update types

b5c789b

update types

b890f34

fixed test

9773832

update snap

68c722c

update test

a5b49e5

update feedback

1e0c4ae

shahzad31 added 4 commits April 29, 2020 14:00

added sorting

68fd60e

Merge branch 'master' into certificate-page

a7245ae

updated tests

7ac98c7

fix type

9aab27b

tylersmalley added v7.8.0 and removed v7.8 labels Apr 29, 2020

shahzad31 added 7 commits April 29, 2020 18:14

update exist field

8f43c47

update margins

e40d236

Merge branch 'master' into certificate-page

eff36cf

update cols

04ec35b

added age info

18e7f1c

Merge branch 'master' into certificate-page

bba5e5e

update mapping

9abd565

andrewvc requested changes Apr 30, 2020

View reviewed changes

justinkambic reviewed Apr 30, 2020

View reviewed changes

justinkambic mentioned this pull request Apr 30, 2020

[Uptime] Flatten dynamic settings object, update saved object mapping #64856

Merged

7 tasks

PR feedback

b8ea75c

andrewvc approved these changes May 1, 2020

View reviewed changes

shahzad31 added 2 commits May 1, 2020 13:33

inline vars

98d1289

var renmae

b2adcda

shahzad31 merged commit 523926f into elastic:master May 1, 2020

shahzad31 deleted the certificate-page branch May 1, 2020 14:04

shahzad31 added a commit to shahzad31/kibana that referenced this pull request May 4, 2020

[Uptime] Certificates page (elastic#64059)

f03acae

shahzad31 mentioned this pull request May 4, 2020

[7.x] [Uptime] Certificates page (#64059) #65052

Merged

shahzad31 added a commit that referenced this pull request May 4, 2020

[7.x] [Uptime] Certificates page (#64059) (#65052)

559644d

andrewvc mentioned this pull request Jun 8, 2020

Add warning about near-expired SSL to "Overview" page elastic/uptime#145

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Uptime] Certificates page #64059

[Uptime] Certificates page #64059

shahzad31 commented Apr 21, 2020 •

edited

Loading

elasticmachine commented Apr 21, 2020

katrin-freihofner left a comment

andrewvc left a comment

justinkambic left a comment

andrewvc left a comment

kibanamachine commented May 1, 2020

[Uptime] Certificates page #64059

[Uptime] Certificates page #64059

Conversation

shahzad31 commented Apr 21, 2020 • edited Loading

Summary

elasticmachine commented Apr 21, 2020

katrin-freihofner left a comment

Choose a reason for hiding this comment

andrewvc left a comment

Choose a reason for hiding this comment

justinkambic left a comment

Choose a reason for hiding this comment

andrewvc left a comment

Choose a reason for hiding this comment

kibanamachine commented May 1, 2020

💚 Build Succeeded

History

shahzad31 commented Apr 21, 2020 •

edited

Loading